The terminology used for adding an existing attribute to a product and creating a new attribute both uses "add."
When editing product, it is "Add an attribute."
When adding attribute, it is "You may add more attributes here."

I would suggest changing the second link to something like "You can create new attributes here," which distinguishes between the functions. Every time I am adding an attribute to a product, I see that link and say "wait, aren't I already doing that?" for a split second before I remember what is going on.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave’s picture

Sounds like a good suggestion. I think we should combine this with #2288607: Doesn't update attribute product classes and use local actions instead of embedding links in help messages.

longwave’s picture

Status: Active » Needs review
FileSize
3.91 KB

The attached patch splits "Add an attribute" into "Create new attribute" and "Add existing attribute" so you can perform both actions directly from the node attributes tab. It also makes both these options available from the product class attributes tab, and the "Create new attribute" action available from the "Add an attribute" page. It removes the separate "You may add more attributes here" message. Finally, it also renames "Add an option" to "Create new option" for consistency.

Some of the uc_attribute help messages perhaps still need to be updated; suggestions welcome!

Status: Needs review » Needs work

The last submitted patch, 2: 2315267-attribute-local-actions.patch, failed testing.

longwave’s picture

Status: Needs work » Needs review
FileSize
4.57 KB

TR’s picture

Status: Needs review » Needs work
Issue tags: +Novice

This change was already made in Ubercart 8.x-4.x. If someone wants to update this patch to apply to 7.x-3.x-dev and to modify it to be consistent with the way things work in 8.x-4.x, then I think this will be easy to add in.