This issue is a continuous effort to bring all ubercart 8.x tests back to green.
I will be posting patches here periodically...those can be committed one by one, or in the end as a big patch

CommentFileSizeAuthor
#5 ubercart-2280871-5.patch3.02 KBParisLiakos
#3 ubercart-2280871-3.3.patch870 bytesParisLiakos
#3 ubercart-2280871-3.2.patch1.59 KBParisLiakos
#3 ubercart-2280871-3.1.patch10.1 KBParisLiakos
#1 ubercart-2280871-1.patch3.03 KBParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new ubercart-2280871-1.patch3.03 KB

Here is what this patch fixes:

  1. After #2279903: Remove hook_schema() implementations for ubercart entities there are no "data" db fields. I uncommented their Field definitions
  2. Fixes user/*/orders view
  3. Fixes CheckoutPanePluginBase does not implement ConfigurablePluginInterface::calculateDependencies()
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Active

Thank you! Committed each part separately, also fixed the 'data' field for UcOrderProduct.

ParisLiakos’s picture

ParisLiakos commented
StatusFileSize
new ubercart-2280871-3.1.patch10.1 KB
new ubercart-2280871-3.2.patch1.59 KB
new ubercart-2280871-3.3.patch870 bytes

thanks! appreciated it for separate commits:)

This patch fixes:

  1. filter_xss() and filter_xss_admin() are removed
  2. uc_product_form_node_type_form_alter() tries to load field definitions from a content type, even on add form, where the type is not set yet
  3. PaymentMethodPane::create() signature is outdated
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Committed all of #3.

ParisLiakos’s picture

ParisLiakos commented
StatusFileSize
new ubercart-2280871-5.patch3.02 KB

thanks!

this one, fixes going from cart to checkout. this will probably fix many fails

  • Commit 95def0f on 8.x-4.x authored by ParisLiakos, committed by longwave: 
    Issue #2280871 by ParisLiakos: Do not show image field selector when...
  • Commit b98887f on 8.x-4.x authored by ParisLiakos, committed by longwave:
    Issue #2280871 by ParisLiakos: Fix signature of PaymentMethodPane::...
  • Commit dd1dc64 on 8.x-4.x authored by ParisLiakos, committed by longwave:
    Issue #2280871 by ParisLiakos: Convert filter_xss() and filter_xss_admin...

  • Commit 9649341 on 8.x-4.x authored by ParisLiakos, committed by longwave: 
    Issue #2280871 by ParisLiakos: Use target_id property instead of value...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Thanks. I think theme_uc_cart_review_table() was not correct though; I made a mistake previously as it shouldn't be calling hook_uc_cart_display(), as by that time the items are UcOrderProduct entities. Instead I applied a quick fix and an @todo to convert the whole thing to Views anyway. Let's see how this gets on with testbot.

The last submitted patch, 1: ubercart-2280871-1.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Fixed

I cheated slightly by skipping five failing assertions and opening #2306379: Rework tax handling and inclusive taxes but at the time of writing the branch is green.

ParisLiakos’s picture

ParisLiakos commented

thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tr’s picture

tr commented
Status: Closed (fixed) » Needs work

Reopening. There have been a lot of changes in D8 core since this was closed, and all of the tests were broken. We now need to make all the tests run green again. I have made great progress over the past few week, and now about half the tests run green. I welcome any contributions towards completing this goal.

tr’s picture

tr commented

Only 2 test fails left to fix!

The exceptions that currently show up in the tests are because of a core change #1835016: Polyfill date input type.
I have reported them as a bug in that original issue and in #2528482: Fix notice in Date::processDate.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think the 'date' problem is what I alluded to in #2088383-1: Datetime FAPI DX where the FAPI type 'date' was handled very differently in D5-7 but has been modernised in D8, but there are no change notices or tests that cover this.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Fixed the last two fails, the remaining notices are the FAPI date bug in core.

tr’s picture

tr commented
Status: Needs work » Fixed

I fixed the last exceptions by using a datetime (and hiding the time part) form field instead of date.

Now that we're green again we can start using #2160791: [D8] Patch testing issue. Marking this as fixed - any new test failures should be opened as individual issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.