Add checkboxes to enable/disable stock level changes when editing orders

Let's kick the bot and see if it will test #1.

The simplest way is to provide an order_save event for rules with original order updated order vars and user could check for status etc and change rules to decrease stock only in some states / statuses or any other rules condition. I already use this on my site...

Re-roll.

Basic tests by myself all passed, have past to client to confirm.

Early feedback suggests no problems.

Background from the clients prospective
Their issue was that when they added the orders via the admin interface, the stock was adjusted here, then again after doing the payment. This differs from the from end where stock is removed during the order process and is not adjusted when payments are processed.

This issue indirectly helps by giving them control here, but they are a bit perplexed for the need and are worried about getting this right.

In 7.x, all other stock incrementing/decrementing happens via Rules (which can be enabled/disabled/modified through the Rules interface). If the stock increment/decrement for admin-edited orders also took place via Rules, then store administrators could decide for themselves whether to apply such changes, and with far more flexibility than a simple checkbox, and the decisions for when and where stock gets incremented/decremented would all be in the same place, in the Rules interface.

Here's a proposed implementation for D7, patched against 7.x-3.x-dev. All stock changes now happen via Rules, so an administrator can decide whether/when admin edits change stock levels by editing the relevant Rules conditions (as was the case with the existing Rules-based stock processing).

Summary of changes:

--Added a new event, 'uc_order_product_updated', to uc_order, which fires on product changes in admin edited orders;
--Added a new action, 'uc_stock_action_adjust_product_stock', to uc_stock, which updates stock levels based on changes in individual products;
--Added a new default rule, 'uc_stock_adjust_on_product_change', to uc_stock, which connects the two.
--Throughout uc_order and uc_stock, removed the direct stock manipulations that happened for edited orders and replaced them with firings of the 'uc_order_product_updated' event.
--Gave all uc_stock-related rules the tag 'uc_stock' so that tag filtering in Rules is useful.

The new rules are enabled by default and reproduce prior behavior so that existing installations don't break.

I've tested this on my local installation, would appreciate any further testing and/or feedback on the implementation. (Would love to see it adopted, of course.)

Robert

Patch isn't in p1 format, so testbot can't apply it ...

Sorry about that. Just switched to git from GUI+SVN and still learning the finer points. I think this is right.

Tried this patch. Made no further modifications to the site and it still decrements stock/qoh twice when using Create Order (as if taking an order over the phone), once when the item is added to the invoice and once when payment is applied. I checked the rules list and there are none. Perhaps I am doing something wrong?

Done, still no rules. Odd there are no rules, at all. I did do an "Upgrade rules" after upgrading from D6 to D7, and seem to recall seeing rules then.

That's where I've been. :\

I've tested the patch for uc3 and it works fine
Now store admins can add / remove products and stock gets updated accordingly!
It's also works fine when dealing with alternate skus of the product :)
This is a must have patch, please commit it!
thanks

hello there!
any news with this patch;
will it be included in the next release;
Do we need any extra tests;
thanks

hello again,
is there anything i can do to "force" this patch to be commited? (test etc?)
thanks

I'll just add that we've now been using the patch for the past two years with no issues.

Hello,

Is there any update regarding this matter? I have tried patch #16 on uc_order.admin.inc using Netbeams IDE 8.2, however I get a message 'patch partly applied' (Ubercart 7.3.10). I installed the patched module, run update.php, cleared cache, run cron but could not find any rule to change stock decrement settings for manual created admin orders.
Also I tried patch #7 but got a message 'patch cannot be applied in the selected context'. I tried the same with Ubercart 7.3.6 with the same result.
In my website customers pay mainly by bank transfer (so not all order will actually be confirmed), therefore in Rules I have set stock decrement for web created orders when a shipment is saved (instead of order creating), this is working fine.
However when creating a manual order by the admin, the stock is inmediately decremented when adding a product. This is a big problem because many of these orders won't be confirmed (when no payment is received).

Is there any way how i can avoid that stock is decremented inmediately when manually creating an order?

All suggestions are welcome. Thanks a lot!

The patch still applies, with minor offsets. The patch affects five separate files - you can't just alter one file and expect the change to work. Read https://www.drupal.org/patch for more information about how to work with patches.

I am re-uploading the patch from #16 so that the "new" testbot can run it - #16 was uploaded before the testbot change, and the new testbot is unable to access any patches prior to that change. I have not altered the patch in any way - it's still the same as in #16.

Thanks a lot TR!

Indeed, you're right, it affects 5 different files. It's working fine now, I could dissable the automatic stock deduction for manually created orders in the Rules. It now works just as I needed!

Learning new things avery day...

Thanks a lot for your help!!

For those who are interested, this patch has been merged into the Backdrop version of Ubercart.

https://github.com/backdrop-contrib/ubercart/pull/237