Support for API 1.1

Hi,

Twitter pull module is compatible with Twitter module but authenticated account should be added on twitter module settings page from which tweets have to be fetched.

To fetch tweets of any account, please apply attached patch and then you just need to add one authenticated account on twitter settings page.

Thanks.

I'm not sure how the patch relates to the issue summary...

I've rolled a patch that uses the Twitter modules' auth_call function to make authenticated requests to the new API. I've also updated the endpoint paths to use the new 1.1 APIs. Since the old APIs are deprecated, I've collapsed get_items and twitter_get_items into one function.

Uploading a new patch with format-patch git attrib info.

Thanks for the patch!

It does need a little more work though:

1. +++ b/twitter_pull.class.inc
   @@ -2,7 +2,7 @@
   - * twitter pull class implementation
   + * Twitter pull class implementation
   
   @@ -41,78 +41,13 @@ class twitter_puller {
   -   * Use the twitter module to get the results.
   +   * Use the Twitter module to get the results.
       *
   -   *  - The twitter module will use an authenticated session to get the tweets
   -   *  - via the twiter 1.1 API.
   +   *  - The Twitter module will use an authenticated session to get the tweets
   +   *  - via the Twitter 1.1 API.
   
   @@ -127,22 +62,27 @@ class twitter_puller {
   -    // Determin the type of request.
   ...
   +    // Determine the type of request.
   

   ... or in this case, less work!

   Please resist the urge to clean up the typos. I know they're annoying and it's so easy to fix them on your way past, but it makes patches much harder to understand and review!

   (I'll happily take a follow-up patch that cleans those up after this is in.)

2. +++ b/twitter_pull.class.inc
   @@ -127,22 +62,27 @@ class twitter_puller {
   +    $force = TRUE;
   

   What's the point of setting this as a variable? I presume it's an optional parameter to twitter_connect()?

3. +++ b/twitter_pull.class.inc
   @@ -162,33 +102,33 @@ class twitter_puller {
   -    // Try to load the status via the twitter api (from the twitter module).
   -    $result = $twitter->call($path, $params, "GET");
   +    // Try to load the status via the Twitter REST api.
   +    $result = json_decode($twitter->auth_request($path, $params, "GET"));
    
        // Create/Empty the tweets array.
        $this->tweets = array();
    
        // Search results return metadata and the rusults in a sub-array
        // We need to parse the actual result array.
   -    $result = isset($result['statuses']) ? $result['statuses'] : $result;
   +    $result = isset($result->statuses) ? $result->statuses : $result;
    
   

   I don't follow this change. Has there been a change to Twitter module's API, as well as the twitter.com's API?

Ok, I've removed all typo fixes except for ones where I was directly adding new comments.

What's the point of setting this as a variable? I presume it's an optional parameter to twitter_connect()?

Yes. I'm modeling this work after Twitter modules' drush_twitter_search() since we're doing very similar work here in twitter_pull. The $force parameter is meant to load tweets to accounts that are not either global accounts (honestly not sure what that means) or that you've previously authenticated via OAuth. The new Twitter 1.1 API allows you to pull tweets from accounts other than yours, so long as you're authenticated with at least one active Twitter account.

I had previously set a variable because I thought in some cases setting $force to true wouldn't be necessary, but I found in my testing that it was always necessary. I've removed the variable (since it never changes) and just always send TRUE in the function call. Thanks for pointing that out.

I don't follow this change. Has there been a change to Twitter module's API, as well as the twitter.com's API?

Yes. The 1.1 API requires OAuth, and Twitter has deprecated non-authenticated requests to the old 1.0 endpoints. Also, all endpoints return data in json, thus the json_decode and subsequent data structure changes.

Same patch as 11 but without the git info in the header so it can be applied with other tools other than git.