Twitter 5.9 module incompatible with Twitter Pull

Same issue.

Twitter 5.9 caused Twitter Pull Authentication to fail.

Reverting to 5.8 fixed this.

Yep many APIs have changed. This is the one killing Twitter Pull.

--- a/cgi-bin/XXX_XXX/sites/all/modules/twitter/twitter.inc
+++ b/cgi-bin/XXX_XXX/sites/all/modules/twitter/twitter.inc
@@ -10,28 +10,47 @@
/**
* Connect to the Twitter API.
*
- * @param object $account
+ * @param object $twitter_account
* An authenticated twitter_account object to be used to authenticate against
* Twitter.
+ * @param bool $access_global
+ * Whether or not to load the global accounts too.
+ * @param bool $force
+ * Loads accounts regardless of other access limits. Should be used with care
+ * and only for limited scenarios that do would not pose a security risk.
+ *
* @return
- * a Twitter object ready to be used to query the Twitter API or FALSE.
+ * A Twitter object ready to be used to query the Twitter API or FALSE.
*/
-function twitter_connect($account = NULL) {
- if (!$account) {
- // Load the first authenticated account.
- $twitter_uid = db_query("SELECT twitter_uid
- FROM {twitter_account}
- WHERE oauth_token <> ''
- AND oauth_token_secret <> '' ")->fetchField();
- $account = twitter_account_load($twitter_uid);
- }
- if ($account) {
- $auth = $account->get_auth();
- if (isset($auth['oauth_token']) && isset($auth['oauth_token_secret'])) {
- return new Twitter(variable_get('twitter_consumer_key', ''), variable_get('twitter_consumer_secret', ''),
- $auth['oauth_token'], $auth['oauth_token_secret']);
+function twitter_connect($twitter_account = NULL, $access_global = FALSE, $force = FALSE) {
+ // If no account was specified, load the first authenticated account.
+ if (empty($twitter_account)) {
+ // Load all authenticated accounts, passing in the same access requirements.
+ $accounts = twitter_load_authenticated_accounts(NULL, $access_global, $force);
+
+ // If no accounts were found, there's a problem.
+ if (empty($accounts)) {
+ watchdog('twitter', 'There are no authenticated Twitter accounts to use for API connections.');
+ }
+
+ // Grab the first authenticated account.
+ else {
+ $twitter_account = reset($accounts);
}
}
+
+ if (!empty($twitter_account)) {
+ $auth = $twitter_account->get_auth();
+ if (isset($auth['oauth_token']) && isset($auth['oauth_token_secret'])) {
+ return new Twitter(
+ variable_get('twitter_consumer_key', ''),
+ variable_get('twitter_consumer_secret', ''),
+ $auth['oauth_token'],
+ $auth['oauth_token_secret']
+ );
+ }
+ }
+
return FALSE;
}

For now I've change my twitter pull twitter_pull.class.inc

- $twitter = twitter_connect();
+ $twitter = twitter_connect(NULL, TRUE);

and made the twitter account global. We only have one account pulling tweets and don't have any other twitter functionality enabled.

@kaosagnt's change in #4 worked for me. I'm also only using one account to pull tweets and no other Twitter functionality.

To clarify the steps:

1) Edit line 171 of twitter_pull.class.inc from:

$twitter = twitter_connect();

to

$twitter = twitter_connect(NULL, TRUE);

2) Go to admin/config/services/twitter and check the "Global" option for the account that you want to pull.

I just ran into the same problem, #6 fixed it for me. Thank you all for posting this!

Attached patch fixes Twitter Pull for me. It will work for Twitter Key setting "@twitter_name" without Global option. For other cases (like "#drupal") you still need at least one global account.

#9 patch worked for me. Thanks!

#9 seems to be working for me as well, and I'm using the 5.10 version of the twitter module.

Thanks for the patch.

Applied patch, Twitter now works fine.

The patch in #9 works for me. +1 to have this committed.

+1 for committing please. Thanks!

Patch in #9 worked perfectly for me as well.

Working for us, too. Thanks!

I've been trying to figure this out for a few days -- #6 worked like a charm. Cheers!

The patch from comment #9 works for me.
looks like it is RTBC.