There are some minor coding standard issues in this module. PFA text file

CommentFileSizeAuthor
#7 coding_standard_fixes-2956284-7.patch8.9 KBSivaprasadC
#3 Final Pareview.png576.25 KBakash.addweb
#2 coding_standard_fixes-2956284-2.patch7.3 KBSivaprasadC
issues.txt5.6 KBSivaprasadC
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sivaprasad C created an issue. See original summary.

SivaprasadC’s picture

SivaprasadC CreditAttribution: SivaprasadC as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: SivaprasadC » Unassigned
Status: Active » Needs review
FileSize
coding_standard_fixes-2956284-2.patch7.3 KB

I have Created the patch for the same. Please review it.

akash.addweb’s picture

akash.addweb CreditAttribution: akash.addweb commented
Status: Needs review » Reviewed & tested by the community
FileSize
Final Pareview.png576.25 KB

@Sivaprasad C, thanks for the patch, I checked it using pareview report & check the result according to it. PFA

SivaprasadC’s picture

SivaprasadC CreditAttribution: SivaprasadC as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented

@Ronak.addweb

Thanks for reviewing. You attached the PAReview screenshot, May I know how and what you reviewed?

Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented
Status: Reviewed & tested by the community » Needs work

@Sivaprasad C, can you please reroll the patch for the new dev version? Your patch no longer applies.

Thanks,

akash.addweb’s picture

akash.addweb CreditAttribution: akash.addweb commented

@Sivaprasad C, You can simply
> Go to 'pareview.sh'
> Add Repo URL https://git.drupal.org/project/twitter_feed.git 8.x-1.x in 'URL to git repository [optional: branch name] *'
> Click on 'Submit Branch' button.
> Now You can see all the standards related errors As attached in Above mentioned screenshot

SivaprasadC’s picture

SivaprasadC CreditAttribution: SivaprasadC as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Needs work » Needs review
FileSize
coding_standard_fixes-2956284-7.patch8.9 KB

@Fidelix

I have rerolled the patch to the new dev version. Kindly review it.

  • Fidelix committed b5a86c2 on 8.x-1.x authored by Sivaprasad C 
    Issue #2956284 by Sivaprasad C, Ronak.addweb, Fidelix: Coding Standard...
Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.