Convert variable_set() and variable_get() calls to config system.

Change notice is here: http://drupal.org/node/1667896

CommentFileSizeAuthor
#4 config_system-2012360-4.patch3.19 KBplopesc
#1 config_system-2012360-1.patch20.36 KBplopesc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Active » Needs review
FileSize
config_system-2012360-1.patch20.36 KB

Patch that converts variables to new config system in Twitter module.

You can validate it checking that values in admin/config/services/twitter/settings page are stored successfully.

Regards

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Version: 7.x-6.x-dev » 8.x-1.x-dev
juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Needs review » Fixed

Committed. Thanks!

http://drupalcode.org/project/twitter.git/commit/0dd3166

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Fixed » Needs review
FileSize
config_system-2012360-4.patch3.19 KB

Patch improved.

Now module handler and config factory are included through dependency injection.

Regards.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Issue summary: View changes
Status: Needs review » Needs work

Triggering the testbot.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review

Triggering the testbot.

The last submitted patch, 1: config_system-2012360-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: config_system-2012360-4.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: [Drupal 8]Convert twitter variables to config system » [Drupal 8] Convert twitter variables to config system

Can you please reroll the patch? Thanks.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: plopesc » Unassigned
Status: Needs work » Closed (works as designed)

This code no longer applies as the module was rewritten in 2014.