Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shruthi Shetty M created an issue. See original summary.

Shruthi Shetty M’s picture

Status: Active » Needs review
FileSize
316 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3133205-1.patch, failed testing. View results

deviantintegral’s picture

Looks like core's TwigEnvironment added a new constructor argument. Can you fix that?

If you felt like updating this to use decoration, I wouldn't object!

Kristen Pol’s picture

Issue tags: +Drupal 9 compatibility
avinashm’s picture

Hi @deviantintegral I really love to fix the issue you mentioned in your comment #4.
Can you please explain it more so that it will be easy for me to fix it.

deviantintegral’s picture

There's a FATAL in the test run at the end that you can see at https://dispatcher.drupalci.org/job/drupal8_contrib_patches/31995/console.

avinashm’s picture

Status: Needs work » Needs review
FileSize
2.11 KB

Hi @deviantintegral
Updated patch with the recommendation in comment #4.

Status: Needs review » Needs work

The last submitted patch, 8: 3133205-8.patch, failed testing. View results

m4olivei’s picture

Sorry all, there was some confusion with the 8.x-1.x branch that has been resolved. The constructor argument issue was resolved in another issue (#2876817: Module incompatible with Drupal 8.3).

Here is a re-roll against 8.x-1.x branch with just the core_version_requirement.

m4olivei’s picture

Status: Needs work » Needs review

  • m4olivei committed 1d36cfa on 3133205-d9-compatibility authored by avinashm
    Issue #3133205 by Shruthi Shetty M, avinashm: Add the '...

  • m4olivei committed 1d36cfa on 8.x-1.x authored by avinashm
    Issue #3133205 by Shruthi Shetty M, avinashm: Add the '...
m4olivei’s picture

Status: Needs review » Fixed

Thanks all! Merged to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.