Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | d9_compatibility-3133205-10.patch | 361 bytes | m4olivei |
| |||
#8 | 3133205-8.patch | 2.11 KB | avinashm |
#2 | 3133205-1.patch | 316 bytes | Shruthi Shetty M |
Comments
Comment #2
Shruthi Shetty M CreditAttribution: Shruthi Shetty M at Specbee commentedComment #4
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedLooks like core's TwigEnvironment added a new constructor argument. Can you fix that?
If you felt like updating this to use decoration, I wouldn't object!
Comment #5
Kristen PolComment #6
avinashm CreditAttribution: avinashm as a volunteer and commentedHi @deviantintegral I really love to fix the issue you mentioned in your comment #4.
Can you please explain it more so that it will be easy for me to fix it.
Comment #7
deviantintegral CreditAttribution: deviantintegral at Lullabot commentedThere's a FATAL in the test run at the end that you can see at https://dispatcher.drupalci.org/job/drupal8_contrib_patches/31995/console.
Comment #8
avinashm CreditAttribution: avinashm as a volunteer and commentedHi @deviantintegral
Updated patch with the recommendation in comment #4.
Comment #10
m4oliveiSorry all, there was some confusion with the 8.x-1.x branch that has been resolved. The constructor argument issue was resolved in another issue (#2876817: Module incompatible with Drupal 8.3).
Here is a re-roll against 8.x-1.x branch with just the core_version_requirement.
Comment #11
m4oliveiComment #14
m4oliveiThanks all! Merged to 8.x-1.x.