CommentFileSizeAuthor
#10 d9_compatibility-3133205-10.patch361 bytesm4olivei
#8 3133205-8.patch2.11 KBavinashm
#2 3133205-1.patch316 bytesshruthi_shetty

Comments

Shruthi Shetty M created an issue. See original summary.

shruthi_shetty’s picture

shruthi_shetty commented
Status: Active » Needs review
StatusFileSize
new 3133205-1.patch316 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3133205-1.patch, failed testing. View results

deviantintegral’s picture

deviantintegral commented

Looks like core's TwigEnvironment added a new constructor argument. Can you fix that?

If you felt like updating this to use decoration, I wouldn't object!

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 9 compatibility
avinashm’s picture

avinashm commented

Hi @deviantintegral I really love to fix the issue you mentioned in your comment #4.
Can you please explain it more so that it will be easy for me to fix it.

deviantintegral’s picture

deviantintegral commented

There's a FATAL in the test run at the end that you can see at https://dispatcher.drupalci.org/job/drupal8_contrib_patches/31995/console.

avinashm’s picture

avinashm commented
Status: Needs work » Needs review
StatusFileSize
new 3133205-8.patch2.11 KB

Hi @deviantintegral
Updated patch with the recommendation in comment #4.

Status: Needs review » Needs work

The last submitted patch, 8: 3133205-8.patch, failed testing. View results

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
StatusFileSize
new d9_compatibility-3133205-10.patch361 bytes

Sorry all, there was some confusion with the 8.x-1.x branch that has been resolved. The constructor argument issue was resolved in another issue (#2876817: Module incompatible with Drupal 8.3).

Here is a re-roll against 8.x-1.x branch with just the core_version_requirement.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs work » Needs review

  • m4olivei committed 1d36cfa on 3133205-d9-compatibility authored by avinashm 
    Issue #3133205 by Shruthi Shetty M, avinashm: Add the '...

  • m4olivei committed 1d36cfa on 8.x-1.x authored by avinashm 
    Issue #3133205 by Shruthi Shetty M, avinashm: Add the '...
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Fixed

Thanks all! Merged to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.