When True Crop generates a new filename, it currently does not take into account the possibility that a previous crop has been deleted.

So for example, if picture.jpg, picture_2.jpg, and picture_4.jpg exist (with picture_3.jpg having been deleted) it will currently create a new crop as picture_3.jpg. It would be better to create picture_5.jpg in that case; this is more logical for the list of files in the administrative interface, and also has the advantage that it avoids reusing the URL of a deleted file (which could be cached somewhere, etc) when possible to avoid doing so.

CommentFileSizeAuthor
#7 truecrop-avoid-reusing-nonsequential-deleted-filename-2766419-7.patch2.77 KBDavid_Rothstein
#5 truecrop-avoid-reusing-nonsequential-deleted-filename-2766419-5.patch2.72 KBDavid_Rothstein
#2 truecrop-avoid-reusing-nonsequential-deleted-filename-2766419-2.patch2.63 KBDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein at Tag1 Consulting commented
Status: Active » Needs review
FileSize
truecrop-avoid-reusing-nonsequential-deleted-filename-2766419-2.patch2.63 KB

Here is a patch.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein at Tag1 Consulting commented
Title: Avoid reusing out-of-sequences names of deleted files for new crops » Avoid reusing out-of-sequence names of deleted files for new crops
Status: Needs review » Fixed

Committed the fix.

  • David_Rothstein committed e8b864a on 7.x-1.x 
    Issue #2766419 by David_Rothstein: Avoid reusing out-of-sequence names...
David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein at Tag1 Consulting commented
FileSize
truecrop-avoid-reusing-nonsequential-deleted-filename-2766419-5.patch2.72 KB

I committed a followup fix to change the query to use db_like() so it will work correctly even if there are wildcard characters in the filename. Attaching the final combined patch that was added to the module via this issue.

  • David_Rothstein committed ce9664f on 7.x-1.x 
    Issue #2766419 by David_Rothstein: Followup to use db_like() in the new...
David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein at Tag1 Consulting commented
FileSize
truecrop-avoid-reusing-nonsequential-deleted-filename-2766419-7.patch2.77 KB

And another followup commit to make this all work when the original image (e.g. "picture.jpg") is the one that was deleted.

  • David_Rothstein committed ca6c482 on 7.x-1.x 
    Issue #2766419 by David_Rothstein: Followup to make the new True Crop...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.