All Deprecated functions like drupal_set_message(), file_upload_max_size(), file_prepare_directory() and deprecated constant FILE_CREATE_DIRECTORY needs to be replaced.

CommentFileSizeAuthor
#10 interdiff_6-10.txt1.27 KBkarishmaamin
#10 3123796-10.patch11.71 KBkarishmaamin
#6 interdiff_3-6.txt3.59 KBmeghasharma
#6 updated_files-3123796-6.patch10.98 KBmeghasharma
#3 3123796-3.patch7.3 KBankithashetty
#2 removed_deprecated_functions-3123796-2.patch5.13 KBankithashetty

Comments

ankithashetty created an issue. See original summary.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Active » Needs review
StatusFileSize
new removed_deprecated_functions-3123796-2.patch5.13 KB

Replaced all deprecated code in the following patch. Please review the same.

Thank You.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting weekend, +DIACWMay2020
StatusFileSize
new 3123796-3.patch7.3 KB

Updated the patch from #2. Please review the new patch attached below.

~vendor/bin/drupal-check .
 15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                       
 [OK] No errors
meghasharma’s picture

meghasharma commented
Assigned: Unassigned » meghasharma
meghasharma’s picture

meghasharma commented
Status: Needs review » Needs work
meghasharma’s picture

meghasharma commented
Assigned: meghasharma » Unassigned
Status: Needs work » Needs review
StatusFileSize
new updated_files-3123796-6.patch10.98 KB
new interdiff_3-6.txt3.59 KB

have fixed coding standard errors.
ran rector tools on tranding images module: no errors reported

my_site_name_dir % vendor/bin/rector process web/modules/contrib/trending_images
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

 45/45 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!
meghasharma’s picture

meghasharma commented
Issue tags: +DIACWSep2020
msuthars’s picture

msuthars
Location Pune
commented
Assigned: Unassigned » msuthars
msuthars’s picture

msuthars
Location Pune
commented
Assigned: msuthars » Unassigned
Status: Needs review » Needs work

@meghasharma Please fix these issues also.

Upgrade Status Report
--------------------------------------------------------------------------------
Trending Images

1 error found.

modules/contrib/trending_images/src/Plugin/Field/FieldFormatter/TrendingImagesFormatter.php:
┌─────────────────────────────────────────────────────----┐
│ STATUS │ LINE │ MESSAGE │
├─────────────────────────────────────────────────────----┤
│ Fix now │ 86 │ Call to deprecated method getStorage() of class │
│ │ │Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0 │
│ │ │ and is removed from drupal:9.0.0. Use │
│ │ │ Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() │
│ │ │ instead. │
│ │ │ │
└────────────────────────────────────────────────────────┘

modules/contrib/trending_images/src/TrendingImagesService.php:
┌───────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├───────────────────────────────────────────────────────┤
│ Ignore │ 107 │ Call to deprecated method isSubclassOf() of class │
│ │ │ Drupal\Core\Entity\EntityTypeInterface. Deprecated in │
│ │ │ drupal:8.3.0 and is removed from drupal:10.0.0. Use │
│ │ │ Drupal\Core\Entity\EntityTypeInterface::entityClassImplement │
│ │ │ s() instead. │
│ │ │ │
└────────────────────────────────────────────────────────┘

karishmaamin’s picture

karishmaamin commented
Status: Needs work » Needs review
StatusFileSize
new 3123796-10.patch11.71 KB
new interdiff_6-10.txt1.27 KB

Fixed issue mentioned in #9, please review