Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Patch fixes a few typos and corrects capitalisation.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 312488-6_priority_normal.patch | 912 bytes | Freso |
| #2 | translation_overview_312488.patch | 5.26 KB | drewish |
| #1 | D6_translation_overview_2.x_translatable_string_fixes3.patch | 5.96 KB | hass |
| D6_translation_overview_2.x_translatable_string_fixes2.patch | 5.59 KB | hass |
Comments
Comment #1
hass CreditAttribution: hass commentedMissed one string. Aside this
$link['options']['attributes'] = array('title' => drupal_ucfirst(trim(implode(', ', $link_title))) .'. '. $action);could really cause some context sensitive issues for translators. We should additionally remove the ucfirst here and leave capitalization up to the translators.Comment #2
drewish CreditAttribution: drewish commentedi committed the attached changes. the parts that touch the $link_title i'm not so into because it's building a compound sentence not individual sentences. i'd like to get some more feed on that change.
Comment #3
hass CreditAttribution: hass commentedWell this $link_title sentence is a real problem... it also made me some headaches :-). Good to think again about this. Building compound sentence is no good idea at all. You should change this to be static. Otherwise people may cannot translate correctly.
t('Unpublished original with a note.')is much easier (more context) and *saver* (case sensitivity is the most important problem here) to translate than the splitted variant - however it may end with more strings to translate. Are you able to remove the compound sentence building?Additional doing an ucfirst is also no good idea. I saw this in panels where a string made lower-case on a "Node" what corrected the sentence in English - but broke the German word "Beitrag" into "beitrag" what is absolutely wrong case. By this example I can safely say - uppercase and lower-case changes should be avoided whenever possible to prevent wrong changes. It wouldn't break here in German, but I cannot say for other languages where sentences may not start with an upper-case letter... but this is now only guessing. A complete sentence like above would solve this problem.
Comment #4
drewish CreditAttribution: drewish commentedI agree in principle that doing these as static strings would be best but the code to do so got very complicated because of the number of options:
Priority - 3 options
Published - 2 options
Has note - 2 options
Action - 3 options
That gives you 36 (3*2*2*3) unique strings. If you'd like to try to roll a patch that does this in a sane looking manner I'd be happy to review it.
Comment #5
hass CreditAttribution: hass commentedI'm sure I don't like it very much to translate this many strings... :-))) Need to think some more about this or a better solution.
Comment #6
Freso CreditAttribution: Freso commentedPerhaps "Normal priority" would've been better than simply "Normal"? "Normal" can be a lot of things in different contexts, "Normal priority" is a bit more limited, actually having a context.
Also, I'm not sure it's proper to "rename" Translation Overview to Translation overview, as it is a proper noun and a title.
Comment #7
drewish CreditAttribution: drewish commentedi was actually more into just not saying anything if it's normal priority...