Expected behavior:
Filter on 'outdated translation' shows me all the nodes that are marked as outdated

Currently it shows... nothing. Maybe my expectations are wrong and this is working as designed though :)

I've added a patch that changes a WHERE clause to a group by (couldn't figure out why there was a WHERE there, maybe this is the functionality I'm not grasping).

Also added sorting and paging in the process.

CommentFileSizeAuthor
#2 translation_overview-filter_and_sorting-1424504.patch802 bytesthijsvdanker
translation_overview-filter-and-sorting-fix.patch603 bytesthijsvdanker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

I cannot see anything about "sorting and paging" you've added.

Outdated functionality is known to be broken. That's bad, but no one found time to fix it till now.
Patch appreciated.

thijsvdanker’s picture

thijsvdanker commented
StatusFileSize
new translation_overview-filter_and_sorting-1424504.patch802 bytes

woops, here's the patch with sorting and paging

thijsvdanker’s picture

thijsvdanker commented
Status: Needs work » Needs review
devad’s picture

devad commented
Issue summary: View changes

I tried the patch...

-  $query->where("(n.nid = n.tnid OR n.tnid = 0) AND n.language <> '' AND n.language IS NOT NULL");
-
+  $query->where("n.language <> '' AND n.language IS NOT NULL");
+  $query->groupBy('n.tnid');

where("(n.nid = n.tnid OR n.tnid = 0) ... ... works nice.
groupBy('n.tnid') do not work nice.

Grouping by n.tnid puts all untranslated nodes (n.tnid = 0) into one group which displays the first node with n.tnid = 0 only and all others are removed from the list.

Other parts of the patch... sorting and paging... work nice for me. Thnx thijsvdanker!

stefan.r’s picture

stefan.r commented
Status: Needs review » Needs work

Setting to NW based on #4