"toolbar-menu-administration" is used in gin theme on the main toolbar. Toolbar menu module is using the same css class name, which leads to a conflict in css styling, and the toolbar menu is not displayed at all.
See #3258279: [toolbar_menu] Styling conflict with toolbar menu module
Use gin theme, and try to add a toolbar menu.
Rename the class name in toolbar_menu module. It should be easier than to try to override/fix it in the gin theme.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3271757-8.patch | 1 KB | elgandoz |
| #5 | After-patch-Toolbar-menu-visible.png | 75.37 KB | preeti.chawla |
| #5 | 3271757-5.patch | 1016 bytes | preeti.chawla |
| #3 | Screenshot 2022-09-20 at 12.28.40.png | 330.85 KB | Geoffrey Vandamme |
| #2 | 3271757-2.patch | 1.1 KB | pasqualle |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
pasqualleThe patch makes the toolbar menu visible in gin.
It seems to be working with flat menus only. From multilevel menus only the first level is displayed.
Comment #3
Geoffrey Vandamme commentedHi Pasqualle,
I've tested the patch for the toolbar menu module, but found an extra issue with the css from admin_toolbar module. Seems like the
first link isn't displayed because of a text-indent coming from tools.css
Comment #4
pasqualleThe patch does not apply to latest 2.x-dev.
Comment #5
preeti.chawla commented@Pasqualle I have created new patch which will work in latest 2.x.dev. By this Toolbar menu will be visible in Gin theme. Please apply and test for same.
Comment #6
preeti.chawla commentedComment #7
elgandoz commentedThe last fix currently throws an error, given patch in #5 uses a jQuery selector (which is deprecated, I believe).
Comment #8
elgandoz commentedPatch attached with the correct selector.
Comment #9
giuseppe87 commented+1 for the #8 patch: without it the menù with Gin isn't shown, with the patch it works.
Comment #10
jan kellermann commentedPatch from comment #8 works for us. Thank you very much.
Comment #13
dydave commentedThanks everyone for the great help on this issue!
I've rolled in the changes from the latest patch at #8 in merge request MR!6 to get the work started on this issue.
I'm not exactly sure I understand how to reproduce the problem here, could somebody please provide more details?
For example, which type of Toolbar is used with the Gin Theme?
Any other potential modules?
Where is this class
toolbar-menu-administrationexactly used in the Gin theme? What causes the issue exactly?(Any link code references pointing to the Gin repo)
Could we please get some screenshots as well?
Additionally, I'm still seeing the issue mentioned above at #3 with extra empty items, when enabling Gin, with any of the Gin Toolbar selected (see in Gin theme settings):
I'm seeing the same exact issue with any of the Toolbar menu items created and displayed in the Toolbar.
Could we try fixing this issue as well as part of a GIN Theme compatibility fix?
Any help, comments, testing and feedback would be greatly appreciated.
Thanks in advance!
Comment #14
dydave commentedComment #15
dydave commented