Deprecated function: preg_match_all(): Passing null to parameter #2

Hello,

I have created MR to fix this warning. Please review.

Thank you!

Let's get some tests around reproducing and solving this.

-  public function tokensPreAlter(&$text, $data, $options) {
+  public function tokensPreAlter(string &$text, $data, $options) {

@binoli-lalani I'm not sure this is the best approach. How can we be sure that the code upstream only passes in a string? In fact, this error report indicates that it's passing in NULL.

I also faced this problem:

And i think the best solution is to check if $text is string and then find matches.
Attached patch here and updated the issue branch.

@fromme thank you for your report and patch. I'm having a hard time reproducing this. Before a patch can be accepted, we need a test that can reproduce and test that the patch fixes the issue. Can you at least help me reproduce it?

@pianomansam, sure.
In my case it happens while using quiz module - on add/edit forms of quizes and questions.
Enabled modules of quiz - https://prnt.sc/QvqqrdtJnKD_

I tested with:
- drupal 10.0.10;
- quiz 6.x-dev#6d6f65d9 + patch for d10 (https://www.drupal.org/project/quiz/issues/3356316)
- token_or 2.1.0

Let me know if i should attached detailed settings of quiz module.

@fromme testing with the quiz module sounds pretty involved, so I'm not sure it will work here. Out of curiosity, what's the token you're using that gives the error?

I was able to reproduce this issue. Apparently, some modules send NULL into the token service 😒

I was able to replicate this issue.

This is the error that I am getting.

Deprecated function: preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\token_or\Token->scan() (line 35 of modules/contrib/token_or/src/Token.php).

Adding a patch.

@bryanmanalo this issue was resolved in release 2.1.1. Are you still experiencing it?

Yes, I experienced the issue in another part of the codebase. However, it could just be a combination of using this and menu_token module.

@bryanmanalo that's unfortunate. Does your patch resolve this issue for your site? If so, we'll need to determine what kind of value is being pass in as $text. I see your patch uses empty($text) while the current release uses !$empty so there must be something that empty catches that false does not. So, in order to get this resolved we need to do the following:

1. Identify the value of $text
2. Write a test that fails
3. Fix the logic so that the test passes

Adding a type declaration or cast could detect or fix this.