Error: "The 'node' entity cannot have a URI as it does not have an ID" when using [node:url:relative] token

I suppose we can put a try/catch around that, but why would you call this on a node that wasn't saved yet? I don't see node_tokens() catching that error, so I would assume that should give you the same error.

I'm not asking why you want that token, I'm asking why you're doing token replacements before the node is saved. An unsaved node has no URL, relative or otherwise.

And I just double-checked that node:url causes the exact same exception.

$node = \Drupal\node\Entity\Node::create(['type' => 'article']);
\Drupal::token()->replace('[node:url]', ['node' => $node]);

Drupal\Core\Entity\EntityMalformedException with message 'The "node" entity cannot have a URI as it does not have an ID'

I am seeing the same message for [node:edit-url] when trying to use something in configuring the default Layout (layout builder) for a node.
In this context, it is a layout configuration, the node doesn't have an ID. I get a stack trace:

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">Drupal\Core\Entity\EntityMalformedException</em>: The &quot;node&quot; entity cannot have a URI as it does not have an ID in <em class="placeholder">Drupal\Core\Entity\EntityBase-&gt;toUrl()</em> (line <em class="placeholder">192</em> of <em class="placeholder">core/lib/Drupal/Core/Entity/EntityBase.php</em>). <pre class="backtrace">node_tokens(&#039;node&#039;, Array, Array, Array, Object)
call_user_func_array(&#039;node_tokens&#039;, Array) (Line: 403)
Drupal\Core\Extension\ModuleHandler-&gt;invokeAll(&#039;tokens&#039;, Array) (Line: 304)
Drupal\Core\Utility\Token-&gt;generate(&#039;node&#039;, Array, Array, Array, Object) (Line: 196)
Drupal\Core\Utility\Token-&gt;replace(&#039;[node:edit-url]&#039;, Array) (Line: 729)

This is a different scenario as described above, however I hope that it can be resolved by not providing these tokens for a node that doesn't yet have an ID.

To the reporter --

Have you considered one of these :

https://www.drupal.org/project/drupal/issues/3069001
https://www.drupal.org/project/ctools/issues/3029323

consider this issue also to fix the error reported :
https://www.drupal.org/project/yoast_seo/issues/3110455

@Berdir the core module layout_builder regularly renders content with sample entities in its UX. These sample entities do not have IDs. As a result, if you use a URI token anywhere on a default layout, the layout builder screen is crashed by this issue.

The function \Drupal\Core\Entity\EntityBase::toUrl() begins with a check for a Null entity ID, and throws an exception if there's no ID. Passing an entity to this function without checking for an ID first is asking for whitescreens -- new, unsaved entities are valid for rendering according to Drupal standards. See the discussion in https://www.drupal.org/project/drupal/issues/3069001 about having contrib modules sensibly handling "preview" content.

+++ b/token.tokens.inc
@@ -569,7 +569,7 @@ function token_tokens($type, array $tokens, array $data, array $options, Bubblea
+    if (($url_tokens = \Drupal::token()->findWithPrefix($tokens, 'url')) && $node->id() !== NULL) {

Could also use empty($node->in_preview). That pre-dates LB (think original node preview) but is also set when LB generates the sample entity.

I don't think in preview is the right thing to check here. you can also preview an existing, already saved node with an ID.

We have an existing case that checks for isNew(), for the generic entity:url token, no strong preference betweenn isNew() and id(). I suppose id() could in edge cases be more reliable.

Remaining tasks:
* As mentioned earlier, node_tokens() in core has the same issue, aka the :url and :edit-url tokens, and a core issue should be opened to improve this.
* Either add checks for other toUrl() calls in token replacements in this module or create a follow-up.
* As usual, tests will make it more likely that this gets committed. Look for exsting tests for those tokens, copy paste with a new node, ensure it doesn't throw an error (assert for not replacing the token).

We used MR 52 to explicitly fix this error in preview (usually I don't enable preview on nodes...)

Rerolled it into the new class for the hooks.

@berdir, will that suffice for the test coverage?

I tried to avoid parsing the URL but came up short and the core tests for Preview didn't help fill in the gaps enough.

It is red/green on the issue though.

Freezing current mr52 state as a patch to give a convenient reference for our composer.json

Oops, wrong file extension. Here's a correction.

I would have just created a new node in code and a kernel test, this seems a bit fragile if core ever changes how previews work, but I guess we'll deal with it then.

Merged.