Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In Drupal 8, if I add a field of type long text with summary and only fill the body, the default handling simply uses the summary field. It should use a trimmed version of the body.
I've prepared a patch which addresses this issue. A simple test is to look at the page source before and after applying the patch when Metatags is enabled. A node which only have the body field completed will have no description field before the patch is applied, and will have the additional content:
<meta property="og:description" content="(Trimmed version of body)" />
afterwards. I would have liked to have used the settings for the field from the view mode that's in use at the time but I couldn't locate a way to find it. This still does better than core though. Core assumes the field is always named body. This patch uses the field name (so field_article_body works in the project for which I've prepared this patch).
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | tokens_body_with_summary-2924873-11.patch | 2.41 KB | joseph.olstad |
| #2 | tokens_body_with_summary-2924873-2.patch | 2.33 KB | istavros |
| |||
| tokens.body-with-summary.patch | 2.33 KB | Nigel Cunningham | |
Comments
Comment #2
istavros CreditAttribution: istavros commentedFixed above patch.
Comment #3
s.messaris CreditAttribution: s.messaris commentedComment #4
Nigel CunninghamComment #5
s.messaris CreditAttribution: s.messaris commentedI have been using this in production for about a month without issue. Setting to RTBC.
Comment #6
istavros CreditAttribution: istavros commentedCan this be committed to the next version?
Comment #7
BerdirThis is relatively complex and could really use a test if we are adding something like that. But maybe that's not actually needed?
Not too happy about all this special logic. Harcoding the teaser view mode is also not very nice.
These tokens are accessing the raw values, not the formatted output. If it's empty then that's how it is.
Token supports rendering fields with the token view mode, so instead of [node:field_something:summary], you do just [node:field_something] and then enable the token view mode for the affected and configure it to use the summary formatted. You do get the field HTML then, but if used in a place that doesn't allow that then it should be stripped away...
Edit: This will not work with the body field, but if you do use that, then you should be able to use node:summary, which basically does what's suggested here and I guess the code was taken from there.
Comment #8
Nigel Cunningham@berdir FWIW, this is essentially a copy-paste of code used elsewhere. Not arguing that it couldn't be improved or unit tested, but that was the basis for the patch and the reason it looks as it does.
More to the point, if this patch is improved, perhaps the other code (I've forgotten the details of what it was, sorry) could be modified too so they're both improved. I'll try to find time to come back to this and do that.
Comment #9
Christopher Riley CreditAttribution: Christopher Riley commentedHas this issue ever been resolved. I am seeing the same issue with the [node:summary] token and before patching I figured I would find out the status considering how long it has been here.
Comment #10
joseph.olstadComment #11
joseph.olstadRe-rolled patch 2 on the head of 8.x-1.x, gets rid of the paths that had no business being there such as
modules/contrib/tokenThis way folks that use composer to apply patches will be able to use this patch.
Comment #12
joseph.olstadComment #13
joseph.olstadAnyone willing to write a test for this please?
Comment #14
joseph.olstadBerdir expressed some concerns with this patch, with that said, we've been using it as there's currently no better solution available.