Summary token not fully handled in fields

Fixed above patch.

I have been using this in production for about a month without issue. Setting to RTBC.

Can this be committed to the next version?

This is relatively complex and could really use a test if we are adding something like that. But maybe that's not actually needed?

Not too happy about all this special logic. Harcoding the teaser view mode is also not very nice.

These tokens are accessing the raw values, not the formatted output. If it's empty then that's how it is.

Token supports rendering fields with the token view mode, so instead of [node:field_something:summary], you do just [node:field_something] and then enable the token view mode for the affected and configure it to use the summary formatted. You do get the field HTML then, but if used in a place that doesn't allow that then it should be stripped away...

Edit: This will not work with the body field, but if you do use that, then you should be able to use node:summary, which basically does what's suggested here and I guess the code was taken from there.

Has this issue ever been resolved. I am seeing the same issue with the [node:summary] token and before patching I figured I would find out the status considering how long it has been here.

Re-rolled patch 2 on the head of 8.x-1.x, gets rid of the paths that had no business being there such as modules/contrib/token
This way folks that use composer to apply patches will be able to use this patch.

Anyone willing to write a test for this please?

Berdir expressed some concerns with this patch, with that said, we've been using it as there's currently no better solution available.

This patch kind of works for me. I have a field name field_feed_item_description which is of type "Text (formatted, long, with summary)" The logic did not apply with the following conditions:

isset($field_item->$property_name) && $field_item instanceOf TextWithSummaryItem

actually i discovered in my case that field_item is

$field_item instanceOf Drupal\text\Plugin\Field\FieldType\TextItemBase

So it might be better to reference this parent if that used by more text formats.

Also isset($field_item->$property_name)

is sort of like saying

isset($field_item->summary)

in web/core/modules/node/node.tokens.inc

we have the following logic:

            // If the summary was requested and is not empty, use it.
            if ($name == 'summary' && !empty($item->summary)) {
              $output = $item->summary_processed;
            }

So my feeling is $field_item->summary is not always available and should not be a condition.

Re-rolled patch 11 as there is a new release.

Added and additional validation to avoid `Call to a member function getComponent() on null` issues.

This broke for me when upgrading token 1.15.0

I have tried both #17 and #18 patches and none worked for me.

Please try this patch and see if it works for you or not.

Screenshot showing token output also shown

This is related: #2854930: [node:summary] token's value get trimmed incorrectly

Back to needing tests.