Deprecated method urlinfo removed from codebase [#2858253]

Deprecated method urlinfo removed from codebase

Comment	File	Size	Author
#5	interdiff.txt	54.1 KB	deepakkumar14
#5	tokens-merged_patches-2858253-5.patch	62.2 KB	deepakkumar14
#5	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 40 fail PHP 7 & MySQL 5.5, D8.4 40 fail
#4	tokens-merged_patches-2858253-4.patch	5.63 KB	rjjakes
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 51 pass PHP 7 & MySQL 5.5, D8.4 51 pass
#2	token-2.patch	5.83 KB	pifagor
#2
	token-1.patch	1.36 KB	pifagor

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

6 March 2017 at 21:40

pifagor created an issue. See original summary.

Comment #2

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor commented 6 March 2017 at 21:47

File	Size
token-2.patch	5.83 KB

1 file was hidden/shown/deleted

File	Size
token-1.patch	1.36 KB

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 29 April 2017 at 11:43

There are a lot of issues about replacing deprecated function call replacements, some only change a single thing, that might make sense in core when there are lots of such calls, but not in a module like token. This is a lot of overhead for me and also for you and looks like gaming/mis-using the credits system.

I'd appreciate it if you combine all your current issues into one, close the others as duplicate and provide a single patch that combines them all. Thank you.

Comment #4

rjjakes CreditAttribution: rjjakes at Acquia Site Studio commented 9 July 2017 at 07:36

File	Size
tokens-merged_patches-2858253-4.patch	5.63 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 51 pass PHP 7 & MySQL 5.5, D8.4 51 pass

I have merged all the open "deprecated" patches and fixed the service issue from here: https://www.drupal.org/node/2858274

Comment #5

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 31 May 2017 at 06:59

File	Size
tokens-merged_patches-2858253-5.patch	62.2 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 40 fail PHP 7 & MySQL 5.5, D8.4 40 fail
interdiff.txt	54.1 KB

Thanks rjjakes i have reviewed the patch in #4 but its doesn't replace all the urlInfo() method with toUrl() and i also get the t() function deprecated in module so i create a patch for replacing all urlInfo() with toUrl() and t() with $this->t().

Comment #6

31 May 2017 at 07:01

Status:

Needs review

» Needs work

The last submitted patch, 5: tokens-merged_patches-2858253-5.patch, failed testing.

Comment #7

rjjakes CreditAttribution: rjjakes at Acquia Site Studio commented 9 July 2017 at 07:42

@deepakkumar14 - seems like a lot of the tests don't like $this->t() perhaps because they're being called as statics to $this doesn't exist? (A guess at this point).

I was under the impression that calling t() as a global was fine - it' definitely not deprecated: https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi...