Can't reference node's menu link from a specific menu [#2850780]

Problem/Motivation

A node can have links in multiple menus (eg. main menu and footer menu). There is a [node:menu-link] token but it's not possible to specify which link it should return in given situation. It just takes the first one returned by the plugin.manager.menu.link service. This makes it impossible to reliably generate url aliases for nodes based on their position in menu of choice (eg. main menu).

Proposed resolution

Implement [node:menu-link-from-menu:?] dynamic token that will only return links from given menu.

Remaining tasks

~~Write patch~~
Review
Write tests

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#20	token_2850780-20.patch	2.26 KB	mighty_webber
#19	token_2850780-19.patch	3.62 KB	pvbergen
#15	2850780-15.patch	3.62 KB	shubham.prakash
#12	2850780-12.patch	3.6 KB	msteurs
#12	2850780-10.patch	3.6 KB	msteurs
#9	2850780-9.patch	3.58 KB	leksat
#2	2850780-2.patch	3.53 KB	blazey

Issue fork token-2850780

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2850780-cant-reference-nodes changes, plain diff MR !122
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

8 February 2017 at 13:19

blazey created an issue. See original summary.

Comment #2

blazey commented 8 February 2017 at 13:57

Assigned:	blazey	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	2850780-2.patch	3.53 KB

Attached patch adds the new [node:menu-link-from-menu:?] token.

It also moves the chained tokens part out of the foreach loop here http://cgit.drupalcode.org/token/tree/token.tokens.inc#n1172. Right now chained tokens are generated as many times as there are tokens. It's redundant because returned values are always the same.

Comment #3

blazey commented 8 February 2017 at 13:56

Issue summary:

View changes

Comment #4

8 February 2017 at 14:27

Status:

Needs review

» Needs work

The last submitted patch, 2: 2850780-2.patch, failed testing.

Comment #5

blazey commented 8 February 2017 at 15:25

Status:

Needs work

» Needs review

Comment #6

blazey commented 8 February 2017 at 16:54

Issue summary:

View changes

Comment #7

blazey commented 8 February 2017 at 16:55

Issue summary:

View changes

Comment #8

blazey commented 8 February 2017 at 16:56

Issue summary:

View changes

Comment #9

leksat commented 7 July 2017 at 11:04

Status	File	Size
new	2850780-9.patch	3.58 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	2850780-2.patch	3.53 KB

Rerolled on 8.x-1.0.

Comment #10

leksat commented 8 July 2017 at 08:01

Status:

Needs review

» Reviewed & tested by the community

Even if we use this patch on a production project for quite some time, I have manually tested the rerolled patch with Token 8.x-1.0 and Drupal 8.3.5. Works as expected!

(Patch #9 provided by me is just a reroll.)

Comment #11

berdir

German

Switzerland

commented 20 December 2017 at 22:37

Status:

Reviewed & tested by the community

» Needs work

This looks useful, but it needs tests. Should be as easy as adding some additional tokens to assert below "// Test [node:menu] tokens." in \Drupal\token\Tests\TokenMenuTest::testMenuTokens()