There is a constant in token.module which is only used once in a service. The service should really use a class constant instead of a define.

CommentFileSizeAuthor
#3 remove_define_from-2643546-3.patch1.4 KBhussainweb
#2 remove_define_from-2643546-2.patch1.39 KBhussainweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Status: Active » Needs review
FileSize
remove_define_from-2643546-2.patch1.39 KB

It's a simple change.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
FileSize
remove_define_from-2643546-3.patch1.4 KB

I forgot the conventions. Skipping the interdiff as the change is small enough to be reviewed in whole.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

I think this would be useful as configuration instead of a hardcoded constant, but moving it makes sense.

  • Berdir committed b15c446 on 8.x-1.x authored by hussainweb 
    Issue #2643546 by hussainweb: Remove define from token.module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.