Issue/motivation

RequestTranslationSubscriber tries to create a url for job items (which contain only locale strings, not entities) but fails because TranslationJobToUrl::convert() can't load an entity by default entity type. That's why we have items in context_upload_queue which will fail on cron runs and will write error log messages into dblog.

Possible solution

Seems like RequestTranslationSubscriber should check for $url to be non-empty before attempting to create the item.

CommentFileSizeAuthor
#4 interdiff-2-4.txt1.19 KBloparev
#4 tmgmt_smartling-2897169-4.patch1.55 KBloparev
#2 tmgmt_smartling-2897169-2.patch912 bytesloparev

Comments

Loparev created an issue. See original summary.

loparev’s picture

loparev commented
StatusFileSize
new tmgmt_smartling-2897169-2.patch912 bytes
loparev’s picture

loparev commented
Status: Active » Needs review
loparev’s picture

loparev commented
StatusFileSize
new tmgmt_smartling-2897169-4.patch1.55 KB
new interdiff-2-4.txt1.19 KB

Added alter hook. For now it's possible to disable/alter context creation for a content from a given job item.

soul88’s picture

soul88
Primary language Ukrainian
Location Ukraine
commented

I don't see why would we need another hook to solve the issue from the initial post. Could you please elaborate more on that?

loparev’s picture

loparev commented

@Soul88 it's just an opportunity to alter context url or disable context at all

soul88’s picture

soul88
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

ok, looks good then. Thank you.

  • Loparev committed b7d850c on 8.x-1.x 
    Issue #2897169 by Loparev, Soul88: Context upload queue items get...

  • Loparev committed b7d850c on 8.x-2.x 
    Issue #2897169 by Loparev, Soul88: Context upload queue items get...
loparev’s picture

loparev commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.