Issue/Motivation
For now we download files that contain unauthorized strings. It happens because of wrong condition in SmartlingTranslator::isReadyForDownload() method.

Possible solution
We should not download file if approvedStringCount equals 0. It means that there are no authorized strings and no translations available.

CommentFileSizeAuthor
#5 interdiff-3-5.txt891 bytesloparev
#5 tmgmt_smartling-wrong-heck-status-5.diff950 bytesloparev
#3 interdiff-1-3.diff981 bytesloparev
#3 tmgmt_smartling-wrong-heck-status-3.diff959 bytesloparev
tmgmt_smartling-wrong-heck-status.diff1.02 KBloparev

Comments

Loparev created an issue. See original summary.

soul88’s picture

soul88
Primary language Ukrainian
Location Ukraine
commented

I believe this still can be a single line of code, which would be better for clarity.

loparev’s picture

loparev commented
StatusFileSize
new tmgmt_smartling-wrong-heck-status-3.diff959 bytes
new interdiff-1-3.diff981 bytes
soul88’s picture

soul88
Primary language Ukrainian
Location Ukraine
commented

I would suggest:

return $request_result['approvedStringCount'] > 0 && $request_result['approvedStringCount'] === $request_result['completedStringCount'];
loparev’s picture

loparev commented
StatusFileSize
new tmgmt_smartling-wrong-heck-status-5.diff950 bytes
new interdiff-3-5.txt891 bytes
soul88’s picture

soul88
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

  • Loparev committed 49f589e on 8.x-1.x 
    Issue #2885843 by Loparev: Wrong check status for files with...
loparev’s picture

loparev commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.