Reviewed & tested by the community
Project:
TMGMT Translator Google
Version:
8.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Apr 2020 at 05:03 UTC
Updated:
26 Sep 2022 at 11:47 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mo_farhaz commentedplease review.
Comment #3
kapilv commentedComment #4
berdirLet's just remove the t() on tests.
This is also going to conflict with #3025137: Convert request method to POST to get past 5000 character limit, maybe just leave out the message that is being removed there otherwise I'll wait with committing this until that is fixed.
Comment #5
pradeepjha commentedComment #6
pradeepjha commentedHi @Berdir
Removed t() function from the same line.
Please review.
Comment #7
Munavijayalakshmi commentedThe patch not working. Needs re-rolled.
Comment #8
Munavijayalakshmi commentedComment #9
Munavijayalakshmi commentedComment #11
somesh1999 commentedI've cleaned some part of the code according to drupal standard.
Comment #12
somesh1999 commentedI have removed most of the warnings and errors according to drupal standard and corrected the file paths in patch. This will work now.
Comment #13
somesh1999 commentedCorrected path for files in patch. Please verify
Comment #14
somesh1999 commentedDue to some confusion I was working on wrong version. I have update the code. Please review.
Comment #16
gersonjlI will work on this.
Comment #17
gersonjlComment #18
gersonjlComment #19
jmizarela commentedI'll review it
Comment #20
jmizarela commentedPatch on #18 fixes all listed issues, is clean and passing reviews. Nicely done, @GersonJL!
Only partial tests were performed on the module at a live site, as it needs a Google API Key billable for translations. I can at least confirm the module is operational after patch, and this should suffice.
Comment #21
jmizarela commented