#2939226: Add support for a translator state field on job items added the ability to have translator state and coresponding icons, but we're not yet using it consistently.

This adds a new method that returns the icon and updates existing code to use it. Also starting to use the icon on content/config translate forms, expecting some fails there.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Status: Active » Needs review
FileSize
6.94 KB

Status: Needs review » Needs work

The last submitted patch, 2: tmgmt-job-state-icon-2942145-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Quite a lot of test updates necessary. Restored the custom prefix on the overview, but kept it as a title on the image and not the link tag.

Also using the most relevant (highest weight) job item icon on the job overview. This makes it a bit slower as before we only looked until we found the first needs-review job item, now we always check them all as we have more than two states to consider. But we already loaded all job items before, so the overhead is limited.

Status: Needs review » Needs work

The last submitted patch, 4: tmgmt-job-state-icon-2942145-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Berdir’s picture

Status: Needs work » Needs review
Berdir’s picture

Added the icons also to the legend on source and job overview.

  • Berdir committed 71581ad on 8.x-1.x
    Issue #2942145 by Berdir: Add method to display job item icon, use it...
Berdir’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.