Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Again related to #2089309: Create job for multiple target languages.
Right now the UX when having multiple jobs to check out is quite bad. The only visible indication beside the initial status message is that the button shows a ".. and continue".
As part of improving working with multiple target languages, this issue is about improving the checkout UI, adding a few features, making others smaller/hiding them by default.
Things we discussed so far:
* Showing a progress element that should how many jobs there are in total and how many are still left. Somewhere on top, like a checkout progress.
* A checkbox that allows to attempt to submit all remaining jobs with the settings of the current job. Either when checking that checkbox or always, it would also be nice if we'd show the jobs then (title and source/target language, maybe item/word count)
* Hide the messages details element if there are no messages. I think this used to work but something broke it.
* Collapse the job items by default, show the count in the details title
* Move the suggestions elements out of the job items details and keep it visible by default.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | tmgmt-multi-checkout-2914080-10-do-not-test.patch | 58.28 KB | Berdir |
| #11 | tmgmt-multi-checkout-2914080-10.patch | 83.45 KB | Berdir |
| |||
| #9 | tmgmt-multi-checkout-2914080-9-interdiff.txt | 15.62 KB | Berdir |
| #9 | tmgmt-multi-checkout-2914080-9-do-not-test.patch | 83.45 KB | Berdir |
| #9 | tmgmt-multi-checkout-2914080-9.patch | 58.28 KB | Berdir |
Comments
Comment #2
BerdirComment #3
BerdirComment #4
BerdirThis is a work in progress patch, changing a lot of stuff and still incomplete an certainly going to fail a lot of tests:
* Fixed messages fieldset to only show up if there are messages
* Load suggestions button is gone, instead they are already loaded, if there are none, the suggestions fieldset is not shown. If there are, the job items fieldset is collapsed.
* Introduced a JobQueue service to deprecate the tmgmt_redirect_* functions that has a lot more functionality that we need to track processed items and handle bulk submission
* Introduced a JobCheckoutManager to add replacement functions of checkout helper functions that use the new JobQueue instead of the deprecated functions.
* In the progress of updating usages of those deprecated functions, will also need to document that properly and everything ;)
* Added a progress bar to the top of the checkout form, it's not very pretty yet though ;)
* Started implementing bulk submit, it works but does not yet use batch, which means there can be a very wait time.
Was hoping to keep the two patches separate, but that won't work anymore with all the refactoring, so two patches for now, one against 8.x-1.x and one against the other issue.
Comment #6
BerdirThis should fix a lot of those test fails.
Comment #8
BerdirFixing some test fails and adding support for using batch.
Comment #9
BerdirNew patch, this considerably improves the progress bar by re-using the standard progress bar UI. Also added the list of pending job labels and languages in a collapsed details element. And added a few tests.
Comment #11
BerdirHad the patch filenames mixed up.
Comment #12
BerdirCommitted.
Comment #15
badrange CreditAttribution: badrange at Digia commentedAm I the only one who have crashed into a bug when requesting translations after this issue was merged? See https://www.drupal.org/project/tmgmt/issues/2951475