Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
We have incoherent cancel buttons now, In JobForm we have a button (btw, it does not work), in JobItemForm we have a link that we are fixing #2650108: Cancel link in JobItemForm does not show up.
In LocalTaskForm we don't have cancel and in LocalTaskItemForm we added it #2646596: Should not be possible to review a completed task.
We added this last two cancel actions as in this forms there was no way to leave them, but now we are adding Breadcrumbs #2652662: Add JobItem breadcrumbs.
And in core by now there is no cancel actions, they are discussing if they want to add them in Drupal 8.1 #116939: Add a Cancel link on forms.
So, what we have to do with the cancel actions? Do we want them? And if so, how they have to be shown?
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | incoherent_cancel_actions-2653464-4.patch | 4.88 KB | johnchque |
| |||
Comments
Comment #2
edurenye CreditAttribution: edurenye at MD Systems GmbH commentedComment #3
miro_dietikerI would vote for breadcrumbs as higher priority items to provide real orientation where a user is.
And consistent to most core currently, i would drop the buttons.
Some areas in core have cancel buttons. But the most relevant areas (content creation, ...) don't.
The button drop patch can be posted here and later once 8.1 contains all buttons, we can revert the patch and readd buttons... also for all locations where the buttons are still missing.
Comment #4
johnchqueDeleted cancel buttons, tests fixed. Cleaned the code a bit.
Comment #5
miro_dietikerCommitted. :-)