I would like to become co-maintainer for this project.

Comments

sathish.redcrackle created an issue. See original summary.

plach’s picture

Category: Support request » Task
Status: Active » Postponed (maintainer needs more info)

Satish, I really appreciate your offer, however usually before granting co-maintainership some work in the issue queue is required to demonstrate one's familiarity with the module's codebase.

Would you be willing to help out in the issue queue for a while?

Additionally, are you targeting the 7.x-1.x branch or the 8.x-2.x one (or both)? They have quite different feature sets and are maintained separately.

sathish.redcrackle’s picture

@plach Thanks for your reply. I will work on the issue queue. I am concentrating on 8.x-2.x.

sathish.redcrackle’s picture

@plach I am working on 8.x.2.x issues. Do you have any issues for me to work on?

imclean’s picture

@sathish.redcrackle, there are plenty of open issues to get through.

plach’s picture

@sathish.redcrackle You should get in touch with @Sam152 then, I'm only "maintaining" the 7.x-1.x branch.

renatog’s picture

Version: 8.x-2.x-dev » 7.x-1.x-dev
Status: Postponed (maintainer needs more info) » Needs review

Hi people.

@plach, I'm interested in helping co-maintainer on branch: 7.x-1.x. I can?

I can help in Issue Queue with bug fixes, closing issues, reviews and help for keep project aways updated and secure.

If you accept I'll be happy to help.

Thank you very much @plach.

Good Work and Good Weekend.

Regards.

plach’s picture

@RenatoG:

Thanks for your offer however, as mentioned in #2, co-maintainership is not granted blindly: you need to demonstrate some familiarity with the code base by working in the queue, providing feedback and patches. I hope this makes sense to you.

plach’s picture

Version: 7.x-1.x-dev » 8.x-2.x-dev

Restoring the previous status as @Sam152 did not reply yet.

AdamPS’s picture

According to #2457455: Support more core content entities, @Sam152 is no longer interested because he is using DS.

I think there are still various people around who would appreciate a title 8.x-2.x because DS is fairly complex and they don't need any of the other features. It could be useful to have a new D8 maintainer.

plach’s picture

I'm happy to appoint a new D8 maintainer, if anyone is stepping up.

AdamPS’s picture

I have some code nearly ready that allows manage display of title in D8. It is based on the dev branch here, plus patches from several fixes in the issue queue, plus one major simplification:

I have removed the setting to control title display per bundle, for the following reasons:

  • Personally I don't find it helpful to have a different UI for different content types.
  • It matches D8 core as $base_field_definitions->setDisplayConfigurable is a per entity setting not a per-bundle setting.
  • It gets rid of most of the code and avoids some of the hacks.
  • It seems better able to extended to other entities - not all of which have an existing per-bundle form where we could add the config option like we do for node using title_form_node_type_edit_form_alter.

My plan is as per my detailed comment on #2353867: [META] Expose Title and other base fields in Manage Display:

  • Release an initial alpha for people to try out, without working automatic tests
  • Raise a core patch to avoid some of the worst hacks (and the alpha would only work properly with the patch).
  • Take a break for 2 months - issues would have to accumulate until I got back, and even then I can't promise unlimited fixing.

I could release my code as a new module title_display, or I could become a maintainer here. I guess it depends on whether you and the community

  • agree with my decision to simplify
  • are happy with my proposed timescales and how much time I can commit
  • think I'm the right person for the job (you can PM me to ask about my experience if you like or check my other modules and credits)
renatog’s picture

I'm also interested in helping to co-maintain 8.x version.

AdamPS’s picture

@RenatoG Excellent. I would be interested in your opinion on

  • my proposal to simplify and remove the setting to control title display per bundle
  • my comment on the other issue
AdamPS’s picture

OK I have tidied the issue queue. I propose that the first step is to check in all the RTBCs and a couple of "Needs Work" that are close, get the automatic tests working/enabled and create an alpha.

I have raised #2923689: Remove setting to control title display per bundle? with some more explanation and I become maintainer I currently favour that direction. If someone else is maintainer and prefers otherwise then fine. I would be happy to co-maintain.

Sam152’s picture

I would simplify the approach in #12 further and reimplement this as an extra field. Setting the 'title' field as display configurable came with untold issues and conflicts with assumptions baked into node and untangling those assumptions could never be done in an entity-type agnostic way.

DS does solve this whole problem space quite nicely, so I can't justify much time to work on this, but would be happy for someone to work on it if it's a problem they have. Putting energy into seeing this land in core would be fantastic too.

AdamPS’s picture

Thanks @Sam152

I understand your frustrations about tangled assumptions, and appreciate the work you did to create the working code. I am optimistic that we can continue the untangling.

I am attracted to the idea of a long term goal to allow $base_field_definitions['xxx']->setDisplayConfigurable for any Core field - it feels like the right architecture. I did experiment with the extra field, but it had it's own complications. It seemed hard to entirely hide from the site-builder that there are two fields, both 'title' and 'field_title'.

AdamPS’s picture

I hope to work on this next week - luckily I have some time available, but only then, not another week. If the maintainers here are willing to grant me provisional commit access then I will clear the list of current issues.

On the other hand I could start a new module if you prefer as the D8 focus is a little different

PS Other entities are working well from a quick test, see notes on #2457455: Support more core content entities

plach’s picture

Personally I was not even planning to open an 8.x branch for Title, so I have no strong opinions on how it should move forward. I'm happy to grant commit access for the 8.x-2.x branch to @AdamPS and/or @RenatoG if they are willing to step up and @Sam152 is fine with that.

7.x-1.x is a completely different beast and I need to sort out the outstanding criticals and release beta1 before anything can progress on that front.

AdamPS’s picture

@plach thanks - I promise not to touch 7.x-1.x, not even with a barge-pole:-)

I think the most important thing is to have all the active maintainers working together on one project. Here is my proposed plan:

  • First off I will commit current "safe", not design-changing open issues on title-8.x-2.x (the RTBC and some of the "needs work" where it's close enough that I can finish it off). This gives everyone proper credit and keeps the issue queue tidy.
  • @plach please could you grant me commit access on that basis?
  • In the meantime, we set up a "working-group" to plan the D8 future - nothing fancy, just an exchange of comments on Drupal.org issues or we could start an online chat.
    • Topic A: design. My ideas are all in the issue queue and child issues of #2924253: [META] Plan for D8. I would welcome feedback by adding comments to the individual issues.
    • Topic B: 'meta': new module or continue on title. The requirement D8 is starting to look quite different from D7 title so I wonder if a new module is better?
    • @RenatoG and @Sam152 if want to be part of this, please add you views.
  • Finally we tidy up and communicate to everyone what we've done: set the interested people up as maintainers for whichever module we end up with; assign issues; add documentation to the project pages etc.

I feel it's worth clarifying the relationship to Display Suite. DS already contains similar function, but it is a large/complex project that adds a lot of extra information to "Manage Display" and (as far as I understand it) invents a whole new mechanism to do so. My goal is to have a very simple module that uses the function in Core, which is actually 90% of what we need. The long-term aim is for the module to cease to exist by coming part of Core, see #2353867: [META] Expose Title and other base fields in Manage Display.

AdamPS’s picture

Update: I have everything working fairly well in a new module Manage Display. The similarity to D7 title is now pretty small, so I think a new module makes sense, and I needed to press on with commits. I have fixed all the open D8 Title module bugs in this new module, and added several features.

I would welcome any applications to be a co-maintainer.

That gives us:

  1. DS: stable, proprietary
  2. Manage Display: working alpha (should be done tomorrow), core-based with core patch required
  3. Title D8: partially working dev, node titles only, core-based, try to work around core limitations without core patches.

As Sam152 pointed out, the approach of 3) is problematic and has limitations. Not sure what anyone else thinks, but I feel that the D8 branch of title might no longer be useful. If you agree, I suggest that the project page could be updated something like this:

Drupal 8

Entity labels now fully support translation and are fields in Drupal 8 core.

A secondary function of the title module is to allow "Manage Display" of the title field. This is not yet available in core (see #2353867: [META] Expose Title and other base fields in Manage Display). In the meantime, options are:

  • Stable module Display Suite includes the ability to manage display of base fields using a proprietary mechanism.
  • Alpha module Manage Display uses native core mechanisms, but needs a patch to core.
edwingiraldo’s picture

Issue summary: View changes
edwingiraldo’s picture

Issue summary: View changes
pifagor’s picture

Status: Needs review » Fixed

The co-maintainers have been added

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

renatog’s picture

Hi @pifagor, how are you?

As cited on the #7, I'm also interested in helping with co-maintainer on branch: 7.x-1.x and 8.x

I can?

I use Title in many projects, and we have 110 open issues to work.

I can help the project to fix these items.

Thank you very much @pifagor, good work and good week.

Best,

pifagor’s picture

Hello @renatog

I am fine, and you? About co-maintainer for the module. Please, write me a private message to discuss the details.

renatog’s picture

Done

pifagor’s picture

I didn't see your message. My email - pifagor87@gmail.com

renatog’s picture

Yes, sure.

Done!

pifagor’s picture

Received a message. I answered you. At the moment it's worth discussing via email. Thank you.