The fix from https://www.drupal.org/node/2757739 has some unintended consequences.

If you do not have a format on your title replacement field, the title will get run through check_markup() with plain_text format applied. If you have Convert line breaks into HTML turned on, your title will now get returned wrapped in p tags.

CommentFileSizeAuthor
#2 title_token_replace_no_format-2875019-2.patch866 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Cheeky Monkey Media commented

rsmylski created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Cheeky Monkey Media commented
Status: Active » Needs review
FileSize
title_token_replace_no_format-2875019-2.patch866 bytes

The attached patch will use check_plain() if no format exists, but will continue to call check_markup() if there is a format.

glynster’s picture

glynster CreditAttribution: glynster commented

@rsmylski this is a perfect fix. +1 RTBC. Is absolutely needed!

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim at GOLEMS GABB for GOLEMS GABB commented

+1

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for GOLEMS GABB, Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed 9b4b428 on 7.x-1.x authored by rsmylski 
    Issue #2875019 by rsmylski, glynster, alex_optim, pifagor: Token...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for GOLEMS GABB, Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed
glynster’s picture

glynster CreditAttribution: glynster commented

Thanks so much for the commit! I have noticed one residual tweak that I think needs adding. HTML Entities are rendering as their code as well

' -> ’

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.