Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pol created an issue. See original summary.

Pol’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2843281.patch, failed testing.

Pol’s picture

Status: Needs work » Needs review
FileSize
22.44 KB

Updated patch.

pol@x230 ~/d/g/title> phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,md,twig,tpl.twig .

FILE: /home/pol/dev/git/title/tests/title.test
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 106 | ERROR | Public method name
     |       | "TitleFieldReplacementTestCase::testFieldReplacementUI"
     |       | is not in lowerCamel format
----------------------------------------------------------------------


FILE: /home/pol/dev/git/title/title.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 28 | WARNING | Format should be "* Implements hook_foo().", "*
    |         | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         | Implements hook_foo_BAR_ID_bar() for
    |         | xyz-bar.html.twig.", "* Implements
    |         | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         | Implements hook_foo_BAR_ID_bar() for block
    |         | templates."
 38 | WARNING | Format should be "* Implements hook_foo().", "*
    |         | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         | Implements hook_foo_BAR_ID_bar() for
    |         | xyz-bar.html.twig.", "* Implements
    |         | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         | Implements hook_foo_BAR_ID_bar() for block
    |         | templates."
----------------------------------------------------------------------


FILE: /home/pol/dev/git/title/views/views_handler_title_field.inc
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
 15 | ERROR | Class name must begin with a capital letter
 15 | ERROR | Class name must use UpperCamel naming without
    |       | underscores
 20 | ERROR | Public method name
    |       | "views_handler_title_field::option_definition" is not
    |       | in lowerCamel format
 30 | ERROR | Public method name
    |       | "views_handler_title_field::options_form" is not in
    |       | lowerCamel format
 44 | ERROR | Public method name
    |       | "views_handler_title_field::advanced_render" is not in
    |       | lowerCamel format
 52 | ERROR | Public method name
    |       | "views_handler_title_field::render_item" is not in
    |       | lowerCamel format
----------------------------------------------------------------------

Time: 1.92 secs; Memory: 22.75Mb

pol@x230 ~/d/g/title> 
pifagor’s picture

Status: Needs review » Needs work
Liam Morland’s picture

Status: Needs work » Needs review
FileSize
12.22 KB

This does not fix everything, but makes a big improvement.

pifagor’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

Related issues: +#3188382: Tag a release
joseph.olstad’s picture

FYI: beta4 was tagged and released today