Problem/Motivation

The comment for the function title_field_views_data_alter() (an implementation of hook_field_views_data_alter() tells that it's an implementation for a different hook hook_views_data_alter().

  * Implements hook_views_data_alter().

And the function signature may be wrong.

(This fix doesn't change any behaviour.)

Proposed resolution

Fix the comment and the function signature.

Remaining tasks

- Create a patch.
- Review the patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 title-fix_comment_for_hook_function_for_views-2827746-2.patch1.16 KBhgoto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hgoto created an issue. See original summary.

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer commented
Status: Active » Needs review
FileSize
title-fix_comment_for_hook_function_for_views-2827746-2.patch1.16 KB

Here is a patch. I'd like someone to review this. Thank you.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

This patch makes senses.

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim at GOLEMS GABB for GOLEMS GABB commented

+1

  • Pol committed ec3ec08 on 7.x-1.x 
    Issue #2827746 by Pol, hgoto: The comment and the signature of...
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Thanks!

hgoto’s picture

hgoto CreditAttribution: hgoto as a volunteer commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.