On title_field_views_data_alter we have a recursive call, we first call entity_get_info to get all infos and then call title_field_replacement_info which calls again entity_get_info.
Here are some stats from one of our projects:
Before patch entity_get_info():
Calls: 29,324
Excl. Wall Time (microsec): 292,669
After patch entity_get_info():
Calls: 20,936
Excl. Wall Time (microsec): 70,270
Before patch title_field_replacement_info():
Calls: 9,720
Excl. Wall Time (microsec): 52,389
After patch title_field_replacement_info():
Calls: 1,332
Excl. Wall Time (microsec): 4,818
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | XHProf__Hierarchical_Profiler_Report.png | 222.25 KB | joelpittet |
| #5 | title-removed-recursive-call-to-entity-get-info-2605040-5-d7.patch | 735 bytes | shaxa |
| #2 | title-removed-recursive-call-to-entity-get-info-2605040-2-d7.patch | 895 bytes | shaxa |
Comments
Comment #2
shaxa commentedComment #3
shaxa commentedComment #5
shaxa commentedComment #6
shaxa commentedComment #7
sylus commentedMakes complete sense and in my albeit not as useful since less data profiling on a distro base install:
Before patch entity_get_info():
Calls: 501
Excl. Wall Time (microsec): 1,834
After patch entity_get_info():
Calls: 425
Excl. Wall Time (microsec): 1,573
Before patch title_field_replacement_info():
Calls: 51
Excl. Wall Time (microsec): 387
After patch title_field_replacement_info():
Calls: 31
Excl. Wall Time (microsec): 238
Comment #8
joelpittetThis is great! RTBC++
Clearing views cache saved 700ms!
Comment #10
plachCommitted and pushed, thanks!