The field for adding a custom CSS class to use in the wrapper tag for the title incorrectly marks valid classes as invalid.

The validation uses drupal_html_class() to check if this field value is correct, but that function is simply a helper function to convert any text into a valid css class. It does not check whether that value is valid.

Here's a good reference for valid characters: http://stackoverflow.com/questions/448981/what-characters-are-valid-in-c...

CommentFileSizeAuthor
#4 interdiff-2137295-3-4.txt1.15 KBtohesi
#4 incorrect_validation-2137295-4.patch1.35 KBtohesi
#3 incorrect_validation-2137295-3.patch1.35 KBtohesi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

criz’s picture

criz
he/him
Location Vienna/Austria
CreditAttribution: criz commented
Priority: Normal » Major

This issue prevents people from defining and using a sustainable system-agnostic components-based html structure in Drupal 7.

If this module is not supporting widely used html standards like BEM or other frameworks it should be considered as a major bug.

See discussion in #2009584: Allow double underscores to pass through drupal_clean_css_identifier as per new CSS standards to see why drupal_html_class() shouldn't be used to validate html classes.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

> See discussion in #2009584: Allow double underscores to pass through drupal_clean_css_identifier as per new CSS standards to see why drupal_html_class() shouldn't be used to validate html classes.

I'm still fighting back on that one, fyi.

tohesi’s picture

tohesi CreditAttribution: tohesi at Wunder commented
FileSize
incorrect_validation-2137295-3.patch1.35 KB

Here's an attempt to bypass the problem using drupal_clean_css_identifier() directly. Certainly not ideal but at least something to allow those BEM classes.

tohesi’s picture

tohesi CreditAttribution: tohesi at Wunder commented
FileSize
incorrect_validation-2137295-4.patch1.35 KB
interdiff-2137295-3-4.txt1.15 KB

Sorry, a new try with the variable names right..

idebr’s picture

idebr CreditAttribution: idebr as a volunteer and at One Shoe commented
Status: Active » Needs review
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

Hi,

This patch makes sense.

Thanks!

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim at GOLEMS GABB for GOLEMS GABB commented

+1

  • Pol committed b663cb1 on 7.x-1.x 
    Issue #2137295 by Pol, tohesi: Incorrect validation for custom wrapper...
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.