After replacing a title, editing it to allow for filtered text and unlimited titles, and then unhiding in the Display tab, I got the following notice when viewing the node:

Notice: Undefined index: safe_value in title_field_formatter_view() (line 100 of /usr/share/drupal-RO/sites/all/modules/title/title.field.inc).

The notice does not go away. Running Drupal 7.22.

CommentFileSizeAuthor
#23 title-safe_value-2040055-22.patch707 bytesplach
#17 notice_undefined-2040055-17.patch542 bytesvisabhishek
#15 undefined_safe_index_replaced_by_index-2040055-15.patch542 bytesflux423
#14 undefined_safe_index_replaced_by_index-2040055-14.patch542 bytesflux423
#13 undefined_safe_index_replaced_by_index-2040055-11.patch542 bytesflux423
#11 title-undefined_safe_index_replaced_by_index-2040055-10.patch542 bytesflux423
#9 title-undefined-safe-value-rerolled-2040055-9.patch542 bytesOlyN
#6 undefined_safe_index_replaced_by_index-2040055-6.patch606 bytescs_shadow
#4 undefined_safe_index_replaced_by_index-2040055-4.patch542 bytescs_shadow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rei’s picture

rei CreditAttribution: rei commented

I got the same error message
activating aggregation=yes in views, trigger the error message.

justindodge’s picture

justindodge CreditAttribution: justindodge commented
Issue summary: View changes

Line 100 of title.field.inc inside of function title_field_formatter_view() has:
$output = isset($items[0]) ? $items[0]['safe_value'] : '';
which looks like it needs to change the key of 'safe_value' to 'value':
$output = isset($items[0]) ? $items[0]['value'] : '';

creatile’s picture

creatile CreditAttribution: creatile commented

I also have the same message. It appears sometime after editing a page.
I am using drupal 7.24 and the following contrib modules :
Media 2x
ck editor link
ck editor link file
entity translation

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Status: Active » Needs review
FileSize
undefined_safe_index_replaced_by_index-2040055-4.patch542 bytes

As suggested by justindodge, replacing 'safe_value' by 'value' fixes this issue. It seems that the 'safe_value' index was not defined. Attached is a patch for the same.

Status: Needs review » Needs work

The last submitted patch, 4: undefined_safe_index_replaced_by_index-2040055-4.patch, failed testing.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
FileSize
undefined_safe_index_replaced_by_index-2040055-6.patch606 bytes

Sorry. The last patch failed testing because I rolled it against wrong branch. This patch should work.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Status: Needs work » Needs review
loudmu’s picture

loudmu CreditAttribution: loudmu commented

patch didn't work for me

OlyN’s picture

OlyN CreditAttribution: OlyN commented
FileSize
title-undefined-safe-value-rerolled-2040055-9.patch542 bytes

I re-rolled the patch in #6 to match the currently latest commit (6316555dbd6c4217e9068cde757bef61342f40f6).

Status: Needs review » Needs work

The last submitted patch, 9: title-undefined-safe-value-rerolled-2040055-9.patch, failed testing.

flux423’s picture

flux423
Primary language English
Location Portland, Maine
CreditAttribution: flux423 commented
Status: Needs work » Needs review
FileSize
title-undefined_safe_index_replaced_by_index-2040055-10.patch542 bytes

Greetings all,
This is my first time sharing a patch with the community!
Please tell me if I'm doing this wrong.

I've created a patch to work on the current version 7.x-1.0-alpha7.

Please review and test.

Status: Needs review » Needs work

The last submitted patch, 11: title-undefined_safe_index_replaced_by_index-2040055-10.patch, failed testing.

flux423’s picture

flux423
Primary language English
Location Portland, Maine
CreditAttribution: flux423 commented
FileSize
undefined_safe_index_replaced_by_index-2040055-11.patch542 bytes

Here's a revised patch to this issue.

Disregard this post.

flux423’s picture

flux423
Primary language English
Location Portland, Maine
CreditAttribution: flux423 commented
FileSize
undefined_safe_index_replaced_by_index-2040055-14.patch542 bytes

Ops.. wrong name to the patch. Re-rolling this to be correct.

flux423’s picture

flux423
Primary language English
Location Portland, Maine
CreditAttribution: flux423 commented
Status: Needs work » Needs review
FileSize
undefined_safe_index_replaced_by_index-2040055-15.patch542 bytes

The patch above needs review.

Status: Needs review » Needs work

The last submitted patch, 15: undefined_safe_index_replaced_by_index-2040055-15.patch, failed testing.

visabhishek’s picture

visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commented
Status: Needs work » Needs review
FileSize
notice_undefined-2040055-17.patch542 bytes

Re-Rolled Patch

Status: Needs review » Needs work

The last submitted patch, 17: notice_undefined-2040055-17.patch, failed testing.

visabhishek’s picture

visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commented
Version: 7.x-1.0-alpha7 » 7.x-1.x-dev
Status: Needs work » Needs review

Moving to latest Dev Branch

visabhishek queued 17: notice_undefined-2040055-17.patch for re-testing.

trumanru’s picture

trumanru CreditAttribution: trumanru commented
Status: Needs review » Reviewed & tested by the community

Works fine!

Thank you, visabhishek!

sgurlt’s picture

sgurlt CreditAttribution: sgurlt at Bright Solutions GmbH commented

Confirm, #17 works fine.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented
Status: Reviewed & tested by the community » Fixed
FileSize
title-safe_value-2040055-22.patch707 bytes 
+++ b/title.field.inc
@@ -97,7 +97,7 @@ function title_field_formatter_settings_summary($field, $instance, $view_mode) {
+  $output = isset($items[0]) ? $items[0]['value'] : '';

This solution would introduce an XSS vulnerability: we need to ensure we always use a save value instead (see the attached patch).

  • plach authored 876abe8 on 7.x-1.x 
    Issue #2040055 by flux423, cs_shadow, visabhishek, plach, OlyN: Fixed...
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.