Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The facebook instant articles module dropped support for the legacy 1.x (RSS) branch for a while now. We should switch to the 2.x (API) branch for Thunder3.
Remaining tasks
Change composer.json and make files. Remove code, that is necessary for the creation of the RSS feed. There are some twig files and a twig filter in thunder_article module, that are not needed anymore.
More occurances have to be investigated
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | thunder-2933086-3.patch | 1.14 KB | truls1502 |
Comments
Comment #2
truls1502See attached patch
Comment #3
truls1502Updated patch
Comment #4
truls1502Comment #5
truls1502There is also a Pull Request: https://github.com/BurdaMagazinOrg/thunder-distribution/pull/637
Comment #6
truls1502Comment #7
chr.fritschComment #8
volkerk CreditAttribution: volkerk at Thunder commentedthunder_fia module stores config and custom code for fb_instant_articles 1.x integration. The fb_instant_articles module does not provide a upgrade path from 1.x to 2.x.
Possible solution is to remove thunder_fia from the distribution and have a separate thunder_fia module with 1.x and 2.x branches reflecting changes in fb_instant_articles.
See #3059036: Move facebook integration to its own module
Comment #9
volkerk CreditAttribution: volkerk at Thunder commentedhttps://github.com/thunder/thunder-distribution/pull/8
Comment #10
chr.fritschWith thunder_fia you can use fb_instant_articles 1.x or 2.x
In Thunder 6.x the fb_instant_articles integration was removed because it is not Drupal 9 ready.