Problem/Motivation

Adam from kurier.at offered us to integrate their paragraphs text split functionality. For me it's a really useful addition.

Proposed resolution

Place the module in the distribution, until we can build it on top of paragraphs clone functionality and move it to d.o.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review

PR: https://github.com/BurdaMagazinOrg/thunder-distribution/pull/428

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs review » Postponed

PP on #2908887: [META] Move to Paragraphs experimental Widget because we want to use the duplicate function of paragraphs

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Postponed » Needs work

Since #2908887: [META] Move to Paragraphs experimental Widget will not happen soon, because there are a few more issues with paragraphs, we will no longer postpone this.

So this will be implemented as a distribution module, and when #2908887: [META] Move to Paragraphs experimental Widget lands, we will refactor it to the duplicate function and move the code outside of Thunder.

chr.fritsch credited maosmurf.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Fixed

Merged

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Fixed » Needs work

We broke the tests -> reopen

daniel.bosen’s picture

daniel.bosen
he/him
CreditAttribution: daniel.bosen at Thunder commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

siva01’s picture

siva01 CreditAttribution: siva01 at Ciklum Western Europe commented

Paragraph split text work only with Paragraphs 8.x-1.1, but in actual Paragraphs 8.x-1.2 it doesn't work.

daniel.bosen’s picture

daniel.bosen
he/him
CreditAttribution: daniel.bosen at Thunder commented

@siva01 this is true. Thunder does not support pParagraphs 1.2 yet. We are still working on that, but have a few issues to solve.
You can see more about this topic here: #2908887: [META] Move to Paragraphs experimental Widget