Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is from another issue which is now closed, but I'm getting the same thing. On the top-right corner is shown: Close,Close or Esc Key,or Esc Key. (Two times Close and 2x Esc key). Is there any way to fix this, even if it's a short term hack?
I'm currently using Thickbox 6.x-1.5 and Splash 6.x-2.5.
Comment | File | Size | Author |
---|---|---|---|
#9 | escape-close.gif | 558 bytes | mikeybusiness |
Comments
Comment #1
sanestrategy CreditAttribution: sanestrategy commentedI would like to add that I think it's probably a jQuery conflict. I'm currently using Lightbox2 for the entire website, including a photo gallery section. The only reason I'm using Thickbox at all is because it's the only one supported by Splash.
So yeah, currently I use Thickbox ONLY for the Splash implementation.
EDIT: The conflict isn't Lightbox2. I completely removed it from Drupal but Thickbox was still displaying the doubletext. The search continues!
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedi second that where to remove?
Comment #3
seanrFound the problem and fixed it. I'll have a release up later today.
Comment #4
dirksonii CreditAttribution: dirksonii commentedPardon making this active again, but I think you forgot to release this particular fix, (either in a full release or even a dev release) and I wanted a quick reminder it was still a problem : )
Comment #5
squares CreditAttribution: squares commentedIt seems as though this behavior is caused by the function _thickbox_doheader in the .module being called multiple times.
I didn't have time to sort out why it would need to call the header more than once... but it was pretty apparent that the header was checking to see if it had already been added with this line:
if ($already_added) { return; }
Unfortunately, it doesn't seem like this var is being set to true at any point.
So I changed
STATIC $already_added = FALSE;
to
global $already_added;
and then made sure to set
$already_added = TRUE;
at the very last line of the function.
Again, this may not be the correct fix for this... but if you have a 4pm deadline, and you need this functionality, it works :D
Comment #6
PetarB CreditAttribution: PetarB commentedI've got this issue as well. I'll try the quick fix above and let you know how it goes.
Comment #7
PetarB CreditAttribution: PetarB commentedHmmm... maybe I'm missing something. I opened splash.module, and while I could find _thickbox_doheader, I could not see $already_added anywhere. Is is possible to get line numbers for the above fix? Thanks!
Comment #8
rezboom CreditAttribution: rezboom commentedthe suggested changes in #5 have to be made in thickbox.module. the fix works for me as well. however, an official fix would be appreciated.
thanks!
Comment #9
mikeybusiness CreditAttribution: mikeybusiness commentedAnother Hack:
I just killed it with an addition to my theme CSS file until it get's ironed out.
I hid the duplicate text.
Then added background text to say what I wanted it to say.
The background image says "Escape to Close."
Comment #10
Rizhaya CreditAttribution: Rizhaya commentedI've changed
to
in the thickbox.module file. It seems to be no duplicates after that.
Comment #11
Shane Birley CreditAttribution: Shane Birley commentedI just added the change in the previous comment and it worked for me. (#10) #5 did not work.
Comment #12
PetarB CreditAttribution: PetarB commentedJust confirming #10 worked.
Thank you!
Comment #13
rc2020 CreditAttribution: rc2020 commentedI can confirm this issue, although with the latest edition of thickbox these fixes do not seem to resolve this problem.
Any suggestions?
Comment #14
ionuts71 CreditAttribution: ionuts71 commented#5 worked also. Two steps:
1. Modify thickbox/thickbox.module file
AND after: Performance -> Clear cached data.
#10 Worked also.
Comment #15
seanrMoving to thickbox as it appears this needs to be fixed there.
Comment #16
seanrLooks like the 6.x version may have fixed this but it persists in 5.x.
Comment #17
Pomliane CreditAttribution: Pomliane commentedThis version of Thickbox is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.
This issue has been automagically closed by a script.
Comment #18
kaustubh51 CreditAttribution: kaustubh51 commentedHi,
I don't know if this is the solution. I was facing the same problem, In my case I tried all of these but no results. Then I disabled the module thickbox. Then I came to know that I was using ajax module and that module internally install ajax thickbox plugin. And both were applied to my form that's why it was showing close close. So using one of them will solve your problem.
Thanks