Problem/Motivation

The autocomplete attribute should be added with the value of 'one-time-code' for the user to improve accessibility and UX.
See also; https://www.drupal.org/project/drupal/issues/3181647, https://www.drupal.org/project/tfa/issues/3456229
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

We recently got this as feedback in an accessibility report, it will help screenreaders better understand the purpose of the inputs. (WCAG 1.3.5)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3456232-5.patch914 bytesnvandijk

Issue fork tfa_email_otp-3456232

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nvandijk created an issue. See original summary.

nvandijk changed the visibility of the branch 3456232-change-autocomplete-attribute to hidden.

nvandijk changed the visibility of the branch 3456232-change-autocomplete-attribute to active.

nvandijk opened merge request !2

nvandijk’s picture

nvandijk commented
Status: Active » Needs review
StatusFileSize
new 3456232-5.patch914 bytes

Created a merge request, patch for own use

mingsong’s picture

mingsong
Location 🇦🇺
commented
Related issues: +#3456229: Change autocomplete attribute to 'one-time-code'
mingsong’s picture

mingsong
Location 🇦🇺
commented

Thanks for the suggestion and the patch.

It sounds faire enough to me. But I would like to have the consistency with the TFA module.

So, let's wait until the TFA module make this move.