Although it is kinda weird to mail back to a TFA mail, its does improve a mail for the mail-score.
We have mailing issues and this appears to be one of the headers that is different.

When applying the following patch, the mails don't appear in the spam.
So could we get a config setting that we get a place to fill the reply-to?

PR incoming

Issue fork tfa_email_otp-3427331

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3427331-introduce-reply-to Comparecompare
    • 1 hidden branch
  • 1.0.x Comparecompare
About issue forks

Comments

MakerTimSWIS created an issue. See original summary.

MakerTimSWIS changed the visibility of the branch 1.0.x to hidden.

mingsong’s picture

mingsong
Location 🇦🇺
commented

Thanks for the patch(fork).

I have a question about the following code,

    if (!in_array($this->validityPeriod, array_keys($options))) {
      $options[$this->validityPeriod] = $this->validityPeriod / 60;
    }

This will provide a possibility to have a validity period that is not included in the allowed list from line 354 in /src/Plugin/TfaValidation/TfaEmailOtpValidation.php

https://git.drupalcode.org/issue/tfa_email_otp-3427331/-/blob/a8f1157a53...

The allowed periods are

$options = [
      60 => 1,
      120 => 2,
      180 => 3,
      240 => 4,
      300 => 5,
      600 => 10,
    ];

An unexpected long period of validity time is a security concern. That is why the allowed options is hard-coded.

mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Active » Needs work