These are the things I can fix:

  1. tfa and tfa_basic contain both contain TfaTrustedBrowser setup.
  2. All tests are written for D7 or assume use of google authenticator.
  3. Example plugins in tfa don't appear in admin gui
  4. D8 Plugins imply implementing interfaces that they don't
  5. defalult encryption is depracted and returns an incorrect value type 'aes_encryption' versus 'encrpytion'
  6. begin() is not called properly by tfa in d8.
  7. Numerous $formstate references need to be turned from array to object

Also if using *ldap*, drupal is not aware of passwords during phone verification stage. so either a) if ldap user bypass password check or b)if ldap use token not password. I would love to discuss this with someone.

I have this issue labelled as 'bug', but I'd like to relabel it a 'plan' :-)

Comments

Techbot created an issue. See original summary.

Techbot’s picture

Techbot commented

Is there any advantages or disadvantages to combining tfa and tfa basic since they already have duplicate files.
At present there are tfa_basic examples that don't work AND tfa examples that don't show in admin (both for drupal8). They share functionality and duplicate code. And so far have made the DX when using d8 and not using google authenticator impossible.

Techbot’s picture

Techbot commented
Issue summary: View changes
Jean Gionet’s picture

Jean Gionet commented

I also just noticed that when I have LDAP authentication setup that users can't setup TFA as when they're prompt for their password during setup it says "INCORRECT PASSWORD". It doesn't seem to realize that the user authenticates using the LDAP password.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Closed (outdated)

This should have been closed a long time ago. Not sure if there was even a tfa_basic version for Drupal 8.