Patches I file on an issue get marked as new but don't get added to the testbot queue.

Issue #2456043: Make exposed date filter operators terminology friendly to non-technical website visitors (D7):
1. I filed the patch in comment #4.
2. The patch failed.
3. I filed the patch in comment #7.
4. The patch failed because I was pointing to the current released branch.
5. I corrected the module version to the dev branch - see comment #9.
6. I clicked Retest in comment #7 - see comment #10.
7. The test request was sent.
8. The request never landed on the testbot queue.
9. I did various things to try to get the testbot to run, all to no avail: Comment #12 - set to needs work
10. Comment #13 - set to needs review
11. Comment #14 - set to needs work
12. Comment #15 - uploaded same patch with new name; test request sent but not added to queue
13. Comment #17 - uploaded same patch with new name; test request sent but not added to queue
14. Comment #18 - uploaded same patch with new name; test request sent but not added to queue
15. Comment #19 - set to needs work
16. Per Mixologic's suggestion on IRC, got the patch to apply locally first, then uploaded same patch with new name and set to needs review; test request sent but not added to queue

Comments

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented
Priority: Normal » Major
charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented

Hmm, while I was typing this, the test ran (sort of, got no results, but that's a different issue). It's still a problem if I've uploaded patches for testing and they don't run, even if running them would lead to a failure to apply. The patches in #4 was completely invalid and the bot still tried to apply it and gave a useful error report.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Yes, that was me manually forcing the test to re-run. Even then Im seeing strange things. This is what is in the log:

[20:18:37] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url http://ec2-52-10-150-126.us-west-2.compute.amazonaws.com/checkout --file sites/default/modules/views/tests/node/views_node_revision_relations.test,sites/default/modules/views/tests/comment/views_handler_filter_comment_user_uid.test,sites/default/modules/views/tests/comment/views_handler_argument_comment_user_uid.test,sites/default/modules/views/tests/taxonomy/views_handler_relationship_node_term_data.test,sites/default/modules/views/tests/field/views_fieldapi.test,sites/default/modules/views/tests/user/views_user.test,sites/default/modules/views/tests/user/views_user_argument_default.test,sites/default/modules/views/tests/user/views_user_argument_validate.test,sites/default/modules/views/tests/user/views_handler_field_user_name.test,sites/default/modules/views/tests/plugins/views_plugin_display.test,sites/default/modules/views/tests/handlers/views_handler_argument_null.test,sites/default/modules/views/tests/handlers/views_handler_field_counter.test,sites/default/modules/views/tests/handlers/views_handler_filter_combine.test,sites/default/modules/views/tests/handlers/views_handler_sort.test,sites/default/modules/views/tests/handlers/views_handler_sort_random.test,sites/default/modules/views/tests/handlers/views_handler_field_boolean.test,sites/default/modules/views/tests/handlers/views_handler_field_custom.test,sites/default/modules/views/tests/handlers/views_handler_filter_equality.test,sites/default/modules/views/tests/handlers/views_handlers.test,sites/default/modules/views/tests/handlers/views_handler_sort_date.test,sites/default/modules/views/tests/handlers/views_handler_area_text.test,sites/default/modules/views/tests/handlers/views_handler_field_file_extension.test,sites/default/modules/views/tests/handlers/views_handler_field.test,sites/default/modules/views/tests/handlers/views_handler_filter_string.test,sites/default/modules/views/tests/handlers/views_handler_filter_date.test,sites/default/modules/views/tests/handlers/views_handler_field_math.test,sites/default/modules/views/tests/handlers/views_handler_filter_numeric.test,sites/default/modules/views/tests/handlers/views_handler_field_url.test,sites/default/modules/views/tests/handlers/views_handler_argument_string.test,sites/default/modules/views/tests/handlers/views_handler_field_file_size.test,sites/default/modules/views/tests/handlers/views_handler_field_xss.test,sites/default/modules/views/tests/handlers/views_handler_filter_in_operator.test,sites/default/modules/views/tests/handlers/views_handler_field_date.test,sites/default/modules/views/tests/styles/views_plugin_style_jump_menu.test,sites/default/modules/views/tests/styles/views_plugin_style.test,sites/default/modules/views/tests/styles/views_plugin_style_unformatted.test,sites/default/modules/views/tests/styles/views_plugin_style_base.test,sites/default/modules/views/tests/styles/views_plugin_style_mapping.test,sites/default/modules/views/tests/views_argument_default.test,sites/default/modules/views/tests/views_analyze.test,sites/default/modules/views/tests/views_access.test,sites/default/modules/views/tests/views_glossary.test,sites/default/modules/views/tests/views_ui.test,sites/default/modules/views/tests/views_handlers.test,sites/default/modules/views/tests/views_view.test,sites/default/modules/views/tests/views_groupby.test,sites/default/modules/views/tests/views_pager.test,sites/default/modules/views/tests/views_translatable.test,sites/default/modules/views/tests/views_exposed_form.test,sites/default/modules/views/tests/views_cache.test,sites/default/modules/views/tests/views_basic.test,sites/default/modules/views/tests/views_upgrade.test,sites/default/modules/views/tests/views_module.test,sites/default/modules/views/tests/views_query.test,sites/default/modules/views/tests/views_argument_validator.test,sites/default/modules/views/tests/templates/views-view--frontpage.tpl.php 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [ERROR: Unknown argument 'sites/default/modules/views/tests/node/views_node_revision_relations.test,sites/default/modules/views/tests/comment/views_handler_filter_comment_user_uid.test,sites/default/modules/views/tests/comment/views_handler_argument_comment_user_uid.test,sites/default/modules/views/tests/taxonomy/views_handler_relationship_node_term_data.test,sites/default/modules/views/tests/field/views_fieldapi.test,sites/default/modules/views/tests/user/views_user.test,sites/default/modules/views/tests/user/views_user_argument_default.test,sites/default/modules/views/tests/user/views_user_argument_validate.test,sites/default/modules/views/tests/user/views_handler_field_user_name.test,sites/default/modules/views/tests/plugins/views_plugin_display.test,sites/default/modules/views/tests/handlers/views_handler_argument_null.test,sites/default/modules/views/tests/handlers/views_handler_field_counter.test,sites/default/modules/views/tests/handlers/views_handler_filter_combine.test,sites/default/modules/views/tests/handlers/views_handler_sort.test,sites/default/modules/views/tests/handlers/views_handler_sort_random.test,sites/default/modules/views/tests/handlers/views_handler_field_boolean.test,sites/default/modules/views/tests/handlers/views_handler_field_custom.test,sites/default/modules/views/tests/handlers/views_handler_filter_equality.test,sites/default/modules/views/tests/handlers/views_handlers.test,sites/default/modules/views/tests/handlers/views_handler_sort_date.test,sites/default/modules/views/tests/handlers/views_handler_area_text.test,sites/default/modules/views/tests/handlers/views_handler_field_file_extension.test,sites/default/modules/views/tests/handlers/views_handler_field.test,sites/default/modules/views/tests/handlers/views_handler_filter_string.test,sites/default/modules/views/tests/handlers/views_handler_filter_date.test,sites/default/modules/views/tests/handlers/views_handler_field_math.test,sites/default/modules/views/tests/handlers/views_handler_filter_numeric.test,sites/default/modules/views/tests/handlers/views_handler_field_url.test,sites/default/modules/views/tests/handlers/views_handler_argument_string.test,sites/default/modules/views/tests/handlers/views_handler_field_file_size.test,sites/default/modules/views/tests/handlers/views_handler_field_xss.test,sites/default/modules/views/tests/handlers/views_handler_filter_in_operator.test,sites/default/modules/views/tests/handlers/views_handler_field_date.test,sites/default/modules/views/tests/styles/views_plugin_style_jump_menu.test,sites/default/modules/views/tests/styles/views_plugin_style.test,sites/default/modules/views/tests/styles/views_plugin_style_unformatted.test,sites/default/modules/views/tests/styles/views_plugin_style_base.test,sites/default/modules/views/tests/styles/views_plugin_style_mapping.test,sites/default/modules/views/tests/views_argument_default.test,sites/default/modules/views/tests/views_analyze.test,sites/default/modules/views/tests/views_access.test,sites/default/modules/views/tests/views_glossary.test,sites/default/modules/views/tests/views_ui.test,sites/default/modules/views/tests/views_handlers.test,sites/default/modules/views/tests/views_view.test,sites/default/modules/views/tests/views_groupby.test,sites/default/modules/views/tests/views_pager.test,sites/default/modules/views/tests/views_translatable.test,sites/default/modules/views/tests/views_exposed_form.test,sites/default/modules/views/tests/views_cache.test,sites/default/modules/views/tests/views_basic.test,sites/default/modules/views/tests/views_upgrade.test,sites/default/modules/views/tests/views_module.test,sites/default/modules/views/tests/views_query.test,sites/default/modules/views/tests/views_argument_validator.test,sites/default/modules/views/tests/templates/views-view--frontpage.tpl.php'.].
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Related issues: +#2273481: Contrib PSR-4 PHPUnit tests are not picked up by PIFR

This is an issue with core's run_tests.sh that is breaking all patches to views.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Active » Closed (fixed)

This was also fixed in drupalci