File entity tests depending on non-core file module [#1417894]

For some reason my file_entity issue patches are failing on patch syntax when the real problem in PIRF seems to be that it's attempting to download the file.module from project/file.

http://qa.drupal.org/pifr/test/218738

Comments

Comment #1

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 26 January 2012 at 18:27

Status:

Active

» Fixed

Well, no... I don't quite understand your comment, but...

The patch just doesn't apply. Let me know if I'm missing something...

rfay@Randys-MacBook-Air:/tmp/file_entity$ git checkout 7.x-2.x
Switched to branch '7.x-2.x'
rfay@Randys-MacBook-Air:/tmp/file_entity$ git apply 1401548-devel-tabs_0.patch 
error: patch failed: file_entity.module:64
error: file_entity.module: patch does not apply
error: patch failed: file_entity.pages.inc:20
error: file_entity.pages.inc: patch does not apply

Comment #2

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 26 January 2012 at 18:30

Hrm, maybe it was a conflict and I just didn't re-roll. Not sure. :/ Thanks for checking.

Comment #3

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 26 January 2012 at 18:30

Well, I guess you move too fast for me, and it doesn't apply because you already committed it. I couldn't figure out what part of the testing log you were referring too.

I do see that the dependencies need to be rebuilt, and the file module excluded, so I'll do that:

drush pdsd file_entity 7.x-2.x-dev
Array
(
    [1233062] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.0-rc1
            [tag] => 7.x-1.0-rc1
        )

    [520766] => Array
        (
            [uri] => file
            [version] => 7.x-1.x-dev
            [tag] => master
        )

)