Colorbox and output options [#1216262]

Hi,
for those who like this module but would like to use it at its full potential, here is a modded version of the 1.1 version (git not available for 7.x dev version...) :

- Added configuration field weight : now it's possible to control via the configuration page the placement of the term of use fieldset.

- Added collapsible & collapsed by default options in the configuration page for the fieldset.

- Added colorbox support :

* If the colorbox module is activated, a new panel is visible on the configuration page, allowing to use a colorbox instead of showing the node in the registration page (useful when the terms page contains a lot of content).

* Two way of linking to the colorbox (not exclusive) : separate link field with custom link text, or automatic link generation in the checkbox label by wrapping the content into [link] my link [/link] tags.

* colorbox's width & height configurable.

This should be working out of the box, just unzip the file in the modules folder.

I let this issue as needs review, please tell me if it's working so i can set it to "patch to be ported".

Ben

Comment	File	Size	Author
#3	terms_of_use-colorbox-1216262-3.patch	9.01 KB	rooby
	terms_of_use-1.1-colorbox_addons.zip	21.53 KB	ben kuper

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Christopher Riley CreditAttribution: Christopher Riley commented 19 September 2011 at 16:49

Works like a champ for me! Can we get this "official"?

Comment #2

Simon Georges CreditAttribution: Simon Georges commented 23 January 2012 at 10:43

Why not using the hook_field_extra_fields() to position the field on the form (instead of a weight field in the interface)?

Anyway, great additions to the module. I'll try to propose a proper patch so the maintainer can integrate it more easily.

Comment #3

rooby CreditAttribution: rooby commented 7 March 2012 at 04:03

Title:	Colorbox and other features (already done !)	» Colorbox and output options
Category:	support	» feature

File	Size
terms_of_use-colorbox-1216262-3.patch	9.01 KB

That's great, thanks.

Here is your version of the module as a patch.

The only things I changed were coding standards fixes like indenting, spacing, comment formatting.
I also changed a b tag to a strong tag.

Works for me.

I agree that weight should be handled using hook_field_extra_fields().

I'll do that when I get a chance if no one beats me to it.

Comment #4

Kars-T CreditAttribution: Kars-T commented 7 July 2012 at 23:06

Version:	7.x-1.1	» 7.x-1.x-dev
Status:	Needs review	» Needs work

thanks for the patch. But the problem I see is that we do a special thing just for colorbox. And there are a lot of modal frame things out there. I would appreciate it if we could make some pluggable approach or have more encapsulation. So the colorbox support is an .inc file and not direct part of the module.