Test coverage

DanielVeza, would you please visit https://www.drupal.org/node/2693767/qa and enable automated testing for MRs on the 2.0.x branch?

I clicked "open merge request" to see if that would kick the testbot off. Nope.

Let's use a checklist to work out what's missing!

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

1. Make sure the project has a development release.
2. From the project page, click "Automated testing".
3. Click Add test / retest.
4. Make sure "new test" is selected. Select the Environment, Core version, and Schedule for testing, and save.
5. Repeat these steps to set up additional schedules.

AFAICT this has been done - looks right to me.

Set up automated testing for:

• The maintained branches of your project, usually weekly, against the latest compatible Core version. Sometimes things change in Drupal core that affect contributed projects, so this will test that your project continues to work with the latest version of Drupal core.
• Patch testing ("Run on commit and for issues"), for each maintained branch. This will make it so when people upload patches or submit merge requests for your project, they will automatically trigger a run of the automated tests.

Is "Run on commit and for issues" the bit that needs flipping here? I can't see that UI, only maintainers can... I think?

Patches (and merge requests) are tested if:

• You have set up automated testing for patches in this branch of your project.
• The issue is set to "Needs Review" or " Reviewed and Tested By the Community." (For more information on status settings, see status settings for an issue.)
• The patch file has a .patch or .diff extension, or a merge request is created.
• The patch has not already failed testing; you can reset manually if you think something went wrong.

Yes! Testbot needed to see an update to the MR in order to wake up. (The other updates last night were me trying a couple of levers that might do it, but they weren't sufficient to appease the test deities.)

I've pushed some coding standards changes to the MR, these should make no changes to your initial tests proper - let's see how that goes :)

(I've got some local WIP which we can add to this also.)

Additionally to the above - I had to click into the test and tell testbot it was OK to run the test, even though tests were failing on the target branch. Now we have a pass!

I have not yet actually reviewed the test, lol. But we have progress :)

Rebased