Taxonomy Role Access: use vocabulary machine name instead of vid in configuration [#1919062]

Hi.
Thanks for this great module. Its exactly what we need for the new version of drupalcenter.de :)
Unfortunately using the vocabulary id as key for the config on admin/config/taxonomy-tools/role-access makes it difficult (or even impossible) to use a clean export of the variable with features.
Guess you've exported the configuration with features using vid:2 and enable the feature on a site with some existing vocabularies. After the import the configuration would point to the wrong vocabulary.

The attached patch changes this to use the machine name of the vocabularies, so it doesn't matter anymore how many vocabularies you have.

Comment	File	Size	Author
#4	vocabulary_machine_name-1919062-3.patch	4.02 KB	SteffenR
#4
#1	vocabulary_machine_name-1919062-2.patch	3.53 KB	stBorchert
#1
	vocabulary_machine_name.patch	1.87 KB	stBorchert

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

stBorchert

he/him

German

CreditAttribution: stBorchert commented 16 February 2013 at 23:27

File	Size
vocabulary_machine_name-1919062-2.patch	3.53 KB

Updated patch (previous one wasn't complete).

Comment #2

martins.bertins CreditAttribution: martins.bertins commented 18 February 2013 at 10:41

Assigned:

Unassigned

» martins.bertins

Thanks for the input. I'll take a look at this.

Comment #3

stBorchert

he/him

German

CreditAttribution: stBorchert commented 18 February 2013 at 12:21

The last patch is still incomplete. I forgot some code in taxonomy_tools_rebuild_access_grants():

<?php
  if (module_exists('taxonomy_tools_role_access') && !$rebuild) {
    // Whether Taxonomy Role access module is enabled.
    $config = variable_get('taxonomy_tools_role_access_vocab_config', array());
    // Only if the vocabulary uses Taxonomy Role access.
    if (!empty($config) && (($vocabulary = taxonomy_vocabulary_load($term->vid)) !== FALSE) && in_array($vocabulary->machine_name, $config)) {
?>