array_unshift($form['#submit'], 'taxonomy_single_tag_submit');
This string is located in foreach section, and in the case of having more than 1 vocabularies it causes the multiply calls of taxonomy_single_tag_submit.

As result, if term name matches this condition:
if (strpos($term_name, ',') !== FALSE || strpos($term_name, '"') !== FALSE)
we getting the term name enclosed with quotes.

CommentFileSizeAuthor
#2 taxonomy_single_tag-1463802.patch1.22 KBquotesBro
taxonomy_single_tag.module.patch782 bytesquotesBro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arhak’s picture

arhak CreditAttribution: arhak commented
Status: Needs review » Needs work

I would prefer to flag an auxiliary variable to TRUE within the if (in_array($vid, $vids_single_tag)) {
to be checked outside the foreach

then, perform the array_unshift($form['#submit'], 'taxonomy_single_tag_submit'); only once,
rather than being checking each iteration whether the submission handler was already unshifted or not

quotesBro’s picture

quotesBro CreditAttribution: quotesBro commented
FileSize
taxonomy_single_tag-1463802.patch1.22 KB

You're right, the previous patch's code was pretty ugly; I'm attaching a new one.

quotesBro’s picture

quotesBro CreditAttribution: quotesBro commented
Status: Needs work » Needs review
arhak’s picture

arhak CreditAttribution: arhak commented
Assigned: Unassigned » quotesBro

I didn't test it, just read it and looks good to go
if you tested it, then commit it

you were granted with repository access

quotesBro’s picture

quotesBro CreditAttribution: quotesBro commented

commited: http://drupalcode.org/project/taxonomy_single_tag.git/commit/7c774dd

quotesBro’s picture

quotesBro CreditAttribution: quotesBro commented
Status: Needs review » Fixed
arhak’s picture

arhak CreditAttribution: arhak commented

granted with "Administer releases"
so, whenever you feel its time for another relesease..

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.