The form action field (Remove Text, Separator, Path Case) are displayed in the opposite order of how they are processed, they should be displayed in the same order to make it clear how to configure the options.

CommentFileSizeAuthor
#3 taxonomy_redirect_n392618_n392626_n392732_n392752.patch6.39 KBDamienMcKenna
#1 taxonomy_redirect-n392752.patch2.72 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
taxonomy_redirect-n392752.patch2.72 KB

Patch attached.

Agileware’s picture

Agileware CreditAttribution: Agileware commented

Thanks for the various patches Damien. Feel free to post one big patch which addresses multiple issues :)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
taxonomy_redirect_n392618_n392626_n392732_n392752.patch6.39 KB

Here's one patch file that covers the following issues:
* #392618: "load into editor" skips the Category field
* #392626: Rewrite JS calls using jQuery
* #392732: Starting path with placeholder can lead to incorrect paths
* #392752: Actions are displayed in wrong order

Agileware’s picture

Agileware CreditAttribution: Agileware commented

Thanks for the patches.

With this one though (#392752: Actions are displayed in wrong order) I don't see the problem.

I just installed a fresh download of 6.x-1.3 and the order of the fields in the table is:

Vocabulary, Term, Path, Path Case, Separator, Remove Text, View in editor, delete

The order of the add redirect fields is:

Vocabulary, Filter, Term, Path, Path Case, Separator, Remove Text

All the options that are in both are in the correct order.

The #392752 patch actually puts them in the wrong order when I try it.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

@agileware: I'm talking about the Add New form vs how the code processes the requested path string.

When I view the Add New Redirect form in 6.x-1.3 this is the order:

  • Path Case
  • Separator
  • Remove Text

When I view the code (taxonomy_redirect_default_term_path() in taxonomy_redirect.module) it is in this sequence:

  • Remove Text
  • Separator
  • Path Case

My patch resolves this so they show in the same sequence as the code so there's no ambiguity on how the path will be processed.

Agileware’s picture

Agileware CreditAttribution: Agileware commented
Status: Needs review » Fixed

Committed to 5.x-1.x and 6.x-1.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.