Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajabNatshah created an issue. See original summary.

Rajab Natshah’s picture

Rajab Natshah’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2939143-2.patch, failed testing. View results

Rajab Natshah’s picture

Status: Needs work » Needs review
andrey.troeglazov’s picture

Assigned: Unassigned » andrey.troeglazov
Sahil.123’s picture

patch 2939143-2.patch not working
no menu links added using this patch getLinks(); returns nothing , as in this we are calling an undefined function.

Rajab Natshah’s picture

Seems that this was fixed in one of the listed issues:
#3019844: Plan for Taxonomy Menu 8.x-3.4 release

Not sure!?
https://cgit.drupalcode.org/taxonomy_menu/tree/src/Controller/TaxonomyMe...

If we search the module we can not see any generateTaxonomyLinks function definition

Status: Needs review » Needs work

The last submitted patch, 2: 2939143-2.patch, failed testing. View results

Rajab Natshah’s picture

Updated the patch to work with 8.x-3.4

Rajab Natshah’s picture

Mohammed J. Razem’s picture

Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Raising the priority to Major and marking as RTBC.

  • dstol committed c0892fa on 8.x-3.x authored by RajabNatshah
    Issue #2939143 by RajabNatshah, andrey.troeglazov, Sahil.123, Mohammed J...
dstol’s picture

Assigned: andrey.troeglazov » dstol
Status: Reviewed & tested by the community » Fixed

Thanks for the reminder Mohammed and the patch Rajab!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture