There are lots of instances where inline comments are not using sentence case. The docblocks are also inconsistent in how the describe parameters. This patch cleans up the documentation to match drupal coding standards.

CommentFileSizeAuthor
#8 taxonomy_menu-cleanup_docs_code_standards-2849950-7.patch54.08 KBandrey.troeglazov
#6 taxonomy_menu-cleanup_docs_code_standards-2849950-6.patch0 bytesandrey.troeglazov
#3 taxonomy_menu-cleanup_docs_code_standards-2849950-3.patch53.4 KBMunavijayalakshmi
taxonomy_menu-cleanup_docs_code_standards.patch44.52 KBjenlampton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, taxonomy_menu-cleanup_docs_code_standards.patch, failed testing.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Unassigned » Munavijayalakshmi
Status: Needs work » Needs review
FileSize
taxonomy_menu-cleanup_docs_code_standards-2849950-3.patch53.4 KB
Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: Unassigned » andrey.troeglazov

I will review that.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
FileSize
taxonomy_menu-cleanup_docs_code_standards-2849950-6.patch0 bytes

Some points were missed, I have fixed them and added new patch.

Status: Needs review » Needs work

The last submitted patch, 6: taxonomy_menu-cleanup_docs_code_standards-2849950-6.patch, failed testing. View results

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Status: Needs work » Needs review
FileSize
taxonomy_menu-cleanup_docs_code_standards-2849950-7.patch54.08 KB

Ops. Wrong file.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: andrey.troeglazov » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good now.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Taxonomy menu release 7-1.6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.