Hello,
I have created a taxonomy with parent and children.
Yesterday I have updated taxonomy_menu to 8.3.3 version.
My taxonomy menu:

  1. has lost all his children
  2. has lost all items weight
  3. has lost...

EDIT: also lost the possibility of changing hierarchy in the menu...

You have understand the problem I think. I though D8 version was more stable then the D7 one, concerning weight and everything, but seems there is still some problem remaining. Maybe it is due to this particular update?

I wanted to warn you because the only solution I found is to recreate my taxonomy menu from scratch... and I'm lucky because I'm steal in pre-prod.

Thank you for your time.

CommentFileSizeAuthor
#13 allow-override-parent-2830188.patch496 bytesniko-
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anou created an issue. See original summary.

anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
CreditAttribution: anou as a volunteer commented
Title: Last update broke exiting taxonomy menu » Last update broke existing taxonomy menu
anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
CreditAttribution: anou as a volunteer commented
Title: Last update broke existing taxonomy menu » 8.3.3 update broke existing taxonomy menu
anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
CreditAttribution: anou as a volunteer commented

I also want to add that when re-creating my taxonomy menu, it does not take into account the taxonomy terms weights it's referring to.
So also had to reorder all menu items to make them match my vocabulary order...

EDIT : finally I do not think this is a good idea once you have reordered your menu differently after you've created the terms. Should be only when you first create the taxonomy menu. See this post https://www.drupal.org/node/2762037#comment-11803631

anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
CreditAttribution: anou as a volunteer commented
Priority: Normal » Major

Also new bug: if I try to change a child position in hierarchy, it is not saved and the term goes back to is previous position in hierarchy... :(

Changing status to major because I think this is too much for one release :-)

Rolling back to 8.2.2 is my only solution for the moment. Sorry I do not have time and the full competence to create a patch for D8 for now.

anou’s picture

anou
Primary language French
Location Collonges au Mont d'Or
CreditAttribution: anou as a volunteer commented
Issue summary: View changes
Chayemor’s picture

Chayemor CreditAttribution: Chayemor commented

I can confirm the bug, using Drupal 8.2.3 , the hierarchy is completely ignored. I am trying to make the taxonomy menu terms be children of links in their parent menu, upon save it gets reordered and they do not become children.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I'm having the same problem and I'm still trying to figure out how to fix it. I'm running on 8.2.4 with the latest stable of Superfish and the patch #95 of https://www.drupal.org/node/2631468.

I can - temporarily - fix the problem sometimes by disabling the expanding children checkbox for all taxonomy menus and then rearrange everything in the menu administration from, but after a clear cache the hierarchy is gone again.

ashopin’s picture

ashopin CreditAttribution: ashopin at Portage CyberTech commented

We're also seeing this issue with the latest update and existing menus. Reverting to the last version fixed the issue.

idiaz.roncero’s picture

idiaz.roncero
Primary language Spanish
Location Madrid
CreditAttribution: idiaz.roncero commented

Can confirm all sort of bugs related to weight, order, childs and parents.

4aficiona2’s picture

4aficiona2 CreditAttribution: 4aficiona2 commented

I can confirm this too. Updated to Drupal 8.2.4 and Taxonomy Menu. Since the update Taxonomy Menu is broken.

niko-’s picture

niko- CreditAttribution: niko- at Adyax commented

Hi

Could anyone explain why in
\Drupal\taxonomy_menu\Plugin\Menu\TaxonomyMenuMenuLink::$overrideAllowed
'parent' => 1 is commented, so seems this is the reason why we can't modify menu items order.

niko-’s picture

niko- CreditAttribution: niko- as a volunteer commented
FileSize
allow-override-parent-2830188.patch496 bytes

Let's allow change parent in taxonomy menu items because menu configuration should be sepereated even if menu was created based on taxonomy vocabulary.

niko-’s picture

niko- CreditAttribution: niko- as a volunteer commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.x-3.3 » 8.x-3.x-dev
Status: Needs review » Reviewed & tested by the community

Great! that makes menu items movable!

CulacovPavel’s picture

CulacovPavel CreditAttribution: CulacovPavel commented

Worked and tested.

But i have same issue as

https://www.drupal.org/node/2867626

After apply patch from

https://www.drupal.org/node/2762037
1. is working, but in taxonomy menu i updated taxonomy, is updated weight in menu, but after clear cache, is reseted.

2. And add your patch from this issue, and drag and drop in menu, weight is changed and drag and drop working.

3 . but if change again weight via taxonomy menu , same bug. bag order that set in point 2.

dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented
Status: Reviewed & tested by the community » Fixed

I don't really consider this RTBC, as it's just removing a comment. I'm going to close this as a dupe of #2762037: Order of Menu items according to the Taxonomy terms order. If someone could jump into testing the patch in #2762037-8: Order of Menu items according to the Taxonomy terms order that would be helpful.

dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented
Status: Fixed » Closed (duplicate)

Whoops, wrong status.

niko-’s picture

niko- CreditAttribution: niko- as a volunteer commented

Hi @dstol

The patch is mostly about the case when user add not term items in taxonomy menu (something like in menu based on taxonomy terms vocabulary user want add special single node page under taxonomy term item)
I think this is not a duplication. Could you confirm that you think that this case is cover with https://www.drupal.org/comment/12023681#comment-12023681

Thanks