Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I ran the coder (code review) module and it showed me some changes.
There are some remaining issues:
Line 432: new hook_theme() function is required to register theme_ functions (Drupal Docs)
function theme_taxonomy_context_subterms($terms) {
severity: criticalLine 40: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
if ($may_cache) {
severity: criticalLine 41: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
severity: criticalLine 49: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
severity: criticalLine 56: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
severity: normalLine 516: string concatenation should be formatted without a space separating the operators (dot .) and a quote
$where = 'WHERE tn.tid = %d ' .
taxonomy_context.install
severity: criticalclick to read moreLine 8: A new schema API has been added in 6.x (Drupal Docs)
switch ($GLOBALS['db_type']) {
Comment | File | Size | Author |
---|---|---|---|
#19 | taxonomy_context-6.x.tgz | 14.56 KB | wojtha |
#3 | taxonomy_context-6.x.tgz | 14.46 KB | Imago |
#2 | taxonomy_context-222641-2.patch | 9.83 KB | pfaocle |
taxonomy_context.diff | 9.58 KB | reikiman |
Comments
Comment #1
pfaocleComment #2
pfaocleSlightly better patch, including all the missing stuff from reikiman's. I haven't bothered with the cosmetic/coding standards changes either, just to keep the patch easier to review for the task in the issue title!
I was just starting to test this when I realised that Drupal 6 now supports the display of taxonomy/term descriptions by default (see this issue). This was the main reason I used the module, so I'm not sure how much more time I will commit to this. Of course, Drupal core still doesn't have the
/taxonomy/vocabulary/x
pages or the context block provided here, so perhaps the module just needs a little rethinking.Hope this helps someone, anway.
Comment #3
Imago CreditAttribution: Imago commentedThank you, it helped me. I am attaching the entire package for 6.1
Comment #4
lee20 CreditAttribution: lee20 commentedWould anyone be interested in creating/maintaining a D6 branch for taxonomy context? I am currently too swamped to add support for D6 right now.
Also, a version 2.0 of Taxonomy Context will hopefully be available soon. I would like to avoid having four branches of development (e.g. 5.x-1.x, 5.x-2.x, 6.x-1.x, 6.x-2.x) as I just don't have the time to support all of them (not to mention the joys of working with multiple CVS branches). So any thoughts or suggestions on this are much appreciated!
Version 2.0 will be adding a ton of features that I have found useful. I will be posting an official announcement soon that will describe the new features.
Comment #5
lonehorseend CreditAttribution: lonehorseend commentedI can probably test a 6.0 version of the module out, but I'm still learning the backend of Drupal, so I'm not comfortable with doing any major programming in it. However, I must say, I really do like the module and would hate to see it be only a version 5 one. It makes working with Drupal a lot easier! I wish I had discovered this module a lot earlier in my Drupal career, it would have saved me a bunch of headaches!
Comment #6
lee20 CreditAttribution: lee20 commentedOkay. I just released a dev of version 2. I think this is the version that I would like to see ported to Drupal 6, but I think it would be best to get any issues worked out with the the D-5 version before porting to D-6.
Comment #7
Fayna CreditAttribution: Fayna commentedSubscribing so I can help test.
Edit: The zipped version of Taxonomy Context in #3 actually works quite well on Drupal 6.2. I haven't received any errors or complaints so far. I was able to configure my Taxonomy block for a vocab and test it out. :-)
Comment #8
giorgio79 CreditAttribution: giorgio79 commentedNice let me test as well :P
Comment #9
wuf31 CreditAttribution: wuf31 commentedsubscribe.. and reviewing..
Comment #10
AgentD CreditAttribution: AgentD commentedSubscribing.
An news on version 2 for Drupal 6?
Comment #11
panji CreditAttribution: panji commentedSubscribing
Comment #12
lonehorseend CreditAttribution: lonehorseend commentedIt works in 6.6, sort of. It gives me what I want that is a list of terms on the vocabulary page and a list of child terms on parent terms. It doesn't, however, do the breadcrumbs for items not in the navigation menu, even if you tell it to do it in the content type. I think that has something to do with how breadcrumbs are handled in Drupal 6. That's what I have Menu Breadcrumb for.
Comment #13
kenorb CreditAttribution: kenorb commentedIn my opinion it's working (#3).
Comment #14
AgentD CreditAttribution: AgentD commentedI'm using this on v6.6 in order to display child terms on the parent term page. Is there any way to set it to only show the child-terms which actually have a node?
Thanks,
Dan
Comment #15
Eugene Fidelin CreditAttribution: Eugene Fidelin commentedWhere i can download the latest version of this module for Drupal 6?
Thanks.
Comment #16
foripepe CreditAttribution: foripepe commentedsubscribe
Comment #17
Summit CreditAttribution: Summit commentedSubscribing, very interested in a D6 working version to test further.
Thanks a lot for the great work done already.
Greetings,
Martijn
Comment #18
wojtha CreditAttribution: wojtha commentedTo get taxonomy_context working on node pages context, change line 301 of the patched module (#3).
Change line 301 from:
$tidscurr = taxonomy_node_get_terms(arg(1));
to
$tidscurr = taxonomy_node_get_terms(node_load(arg(1)));
First argument of this function must be an node object now in D6: http://api.drupal.org/api/function/taxonomy_node_get_terms/6
After this small fix context breadcrumbs on node pages are showing properly (if you enable it on nodetype form) and also an appropriate item in a taxonomy_context menu is activated.
Comment #19
wojtha CreditAttribution: wojtha commentedUpdated ported version of the module (#3). (Just the one line changed ^^^)
Comment #20
radj CreditAttribution: radj commentedsubscribe
Comment #21
Starminder CreditAttribution: Starminder commentedsubscribe
Comment #22
chawl CreditAttribution: chawl commentedsubs
Comment #23
NancyDruIs this port based on 5.x-1.x or 5.x-2.x?
Comment #24
wojtha CreditAttribution: wojtha commented@NancyDru: 5.x-1.x probably
From first patch:
Comment #25
NancyDruI am working exclusively with V2, which seems to be the future of this module. The sooner it is fully tested by the community, the sooner it will be ported to D6.
Comment #26
mcreature CreditAttribution: mcreature commentedThank you Nancy. I am not working with a Drupal 5 dev at the moment, but as soon as I have some more time, I will put one up and help test
Comment #27
ccshannon CreditAttribution: ccshannon commentedI downloaded the module at Post #19. I am using Drupal 6.10.
I can see the admin settings at admin/settings/taxonomy_context
But there are no blocks for my vocabularies on the Blocks admin page.
I tried disabling and re-enabling the module, but Blocks do not appear on Blocks admin page.
Thanks. Let me know if you have further questions.
Comment #28
ccshannon CreditAttribution: ccshannon commentedI disabled, uninstalled, then deleted the module folder for the item at #19, downloaded the item from post #3.
Reinstalled, Enabled module. Went to settings page, saved default configuration.
Went to Blocks admin. No Blocks.
No one else is seeing this issue? Again, Drupal 6.10.
Went back to the #19 module after a disable/uninstall.
No blocks show up in the Blocks page.
Comment #29
NancyDruI haven't started trying to do D6 yet.
Comment #30
ccshannon CreditAttribution: ccshannon commentedI did notice the thread marked as "postponed" but I was curious if anyone else who downloaded either of the above two ports had experienced the same issue. Some above comments lead me to believe people have it working in D6.x installations.
This module does exactly what I need (for D5) but I chose D6 to build my customer's online store with, and I really can't go back. Most everything I need is available for D6, though. I'd love to have this for D6. I'm working with Taxonomy Menu and am having all sorts of weird issues with it, and Taxonomy Menu of course doesn't have the contextual abilities I'd like.
In any case, thank you for taking it on, good luck with it, and I am happy to assist in any way you need. :)
Comment #31
EliteMonk CreditAttribution: EliteMonk commentedfor support i18n for multilanguage sites:
In function taxonomy_context_menu_tree($vid, $tid = NULL) need change
to
In function theme_taxonomy_context_term($term) need change
to
In function taxonomy_context_block($op = 'list', $delta = 0, $edit = array()) need change
to
Comment #32
binhcan CreditAttribution: binhcan commentedBig thanks for this, EliteMonk It's working on my localhost and I am planning to update it on my server soon.
Comment #33
NancyDruNote that
module_exists('i18ntaxonomy')
is much slower thanfunction_exists('tt')
.Comment #34
binhcan CreditAttribution: binhcan commentedStill after #32, the vocabulary page is not displaying any term/node.
Comment #35
asb CreditAttribution: asb commentedsubscribing
Greetings, -asb
Comment #36
EliteMonk CreditAttribution: EliteMonk commentedIn #31 added i18n support for block name
In function taxonomy_context_block($op = 'list', $delta = 0, $edit = array()) need change
to
Comment #37
EliteMonk CreditAttribution: EliteMonk commentedIn #31 update i18n support for subterms
In function theme_taxonomy_context_term($term) need change
to
Comment #38
EliteMonk CreditAttribution: EliteMonk commentedAdditional setting in setting page for this module. Allow display count nodes after term name in block.
====================
After this code:
need paste this code:
====================
In function taxonomy_context_menu_tree($vid, $tid = NULL) need replace
to
====================
In function taxonomy_context_admin_settings() need replace
to
Comment #39
EliteMonk CreditAttribution: EliteMonk commentedQuestion:
How make new project on this site expamle "Taxonomy Context 2" or update old project...
Comment #40
przemu CreditAttribution: przemu commentedIs this port to Drupal 6 working good?
And there is a question for EliteMonk. You have made some modifications. Maybe you can pack modified files into archive and publish here?
It would be better for users looking for Drupal 6 port.
Comment #41
venusrising CreditAttribution: venusrising commentedWhere can we find a Drupal 6 Port to test?
Comment #42
asb CreditAttribution: asb commented> Where can we find a Drupal 6 Port to test?
Still no answer?
Greetings, -asb
Comment #43
NancyDruAn alpha version of 6.x is now available. It does not yet include any of the i18n stuff. It is mostly the package from #3.
@ccshannon: I do see blocks on Drupal 6.13.
Comment #44
NancyDruThe i18n changes are committed to the 6.x-2.x branch and included in 6.x-2.x-alpha2.
@EliteMonk: I am English-only, so all I could so was syntax check the code. Please test it thoroughly and open new issues if you find any. BTW, I did the changes a bit differently than your code, but the effect should be the same.
Comment #45
asb CreditAttribution: asb commented@NacyDru:
Thank you!
-asb
Comment #46
ccshannon CreditAttribution: ccshannon commentedNancyDru, you can solve my mysteries, any day! Thanks! :D
Comment #47
NancyDruThere is a lot of community testing needed. I have already run into several issues in my limited use of the module. Ir would help a lot for other people who use it in different ways to check it out. As you can see I have already created a third alpha release and a -dev on top of that. As I get some of the more significant issues resolved, you can expect more alphas to come out. Please pay particular attention to the way the settings interact - I know there are some issues there. And I know that subterms are not acting right.
Comment #49
asb CreditAttribution: asb commentedComment #50
kenorb CreditAttribution: kenorb commentedDrupal 6 is no longer officially supported. If you think this issue is still relevant for 8.x, feel free to re-open.