Hi All

I have attached a patch that fixes a small security issue and adds some functionality.

Security fix : tamauth_page() included a user_load_by_name that loaded the user from the webseal headers before checking if the user was valid.
The page load at /user/tam was authenticated but no session was created..

Admin UI for role mappings added.

hook_tamauth_login_event is added so other modules can do something on webseal logins.

Tom

CommentFileSizeAuthor
#3 tamauth-security-ui-hook-2328555-3.patch11.99 KBjoel.gilchrist
#1 tamauth-security-ui-hook-2328555-1.patch5.27 KBthelmer

Comments

thelmer’s picture

thelmer commented
StatusFileSize
new tamauth-security-ui-hook-2328555-1.patch5.27 KB
thelmer’s picture

thelmer commented
Issue summary: View changes
joel.gilchrist’s picture

joel.gilchrist commented
StatusFileSize
new tamauth-security-ui-hook-2328555-3.patch11.99 KB

Hi thelmer,

I extended the admin ui for role mapping to be table based and to use a role select list instead of free text. Also added a textfield for the redirect. Please review.

I'll admit I have an ulterior motive and will be adding another issue for auto login capability and I'll be updating the admin ui for that as well.

joel.gilchrist’s picture

joel.gilchrist commented
Status: Active » Needs review
joel.gilchrist’s picture

joel.gilchrist commented

See https://www.drupal.org/node/2499649#comment-10025595 where this patch has been merged into work going on in that issue.